From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 3068513832E for ; Mon, 25 Jul 2016 02:58:19 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 6FE57E094C; Mon, 25 Jul 2016 02:58:15 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id EC856E0944 for ; Mon, 25 Jul 2016 02:58:14 +0000 (UTC) Received: from [192.168.0.20] (ip68-5-185-102.oc.oc.cox.net [68.5.185.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id 9D2C7340C97 for ; Mon, 25 Jul 2016 02:58:13 +0000 (UTC) Subject: Re: [gentoo-portage-dev] [PATCH] emerge: add --search-fuzzy and --search-fuzzy-cutoff options (bug 65566) To: gentoo-portage-dev@lists.gentoo.org References: <1459746182-13420-1-git-send-email-zmedico@gentoo.org> <57022835.2060304@gentoo.org> <57074E05.4030202@gentoo.org> <570796ED.8040608@gentoo.org> From: Zac Medico Message-ID: <0575804e-0b0a-1e49-168f-0836f84d4524@gentoo.org> Date: Sun, 24 Jul 2016 19:58:11 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: <570796ED.8040608@gentoo.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Archives-Salt: 6e0e46f5-1623-4940-8969-fdc02ba0034c X-Archives-Hash: 163e62e795b1889a719b66b4aefac1da On 04/08/2016 04:33 AM, Alexander Berntsen wrote: > On 08/04/16 08:21, Zac Medico wrote: >> Reverse? You want it to measure dissimilarity? Not sure what you >> mean. > Sorry, I meant reverse the *docs* to mean "find things that are at > least 50% similar" rather than "cut off things that aren't above the > 0.5 threshold". I.e. use an inclusive sentence. I feel that this is > more clear. > >> I just want it to fail if the input is invalid. > Yes, I just realised you checked if it were <=, not just <. I think > this is a bad idea. It's easily missed -- I just missed it last time > around. I would suggest to make it fail early, rather than set it to > 0.0 which you then set to None. Just set it to None immediately. > I've just sent "[PATCH] emerge: add --fuzzy-search and --search-similarity (bug 65566)" which hopefully accounts for all of the previous feedback. -- Thanks, Zac