From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 399A0138010 for ; Mon, 1 Oct 2012 03:05:21 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id C1B5F21C015 for ; Mon, 1 Oct 2012 03:05:20 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id B132221C004 for ; Mon, 1 Oct 2012 00:48:39 +0000 (UTC) Received: from [192.168.26.5] (ip98-164-193-252.oc.oc.cox.net [98.164.193.252]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id 0287633D748 for ; Mon, 1 Oct 2012 00:48:38 +0000 (UTC) Message-ID: <5068E866.3030806@gentoo.org> Date: Sun, 30 Sep 2012 17:48:38 -0700 From: Zac Medico User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:15.0) Gecko/20120901 Thunderbird/15.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Package Manager Specification discussions X-BeenThere: gentoo-pms@gentoo.org X-BeenThere: gentoo-pms@lists.gentoo.org Reply-To: gentoo-pms@lists.gentoo.org MIME-Version: 1.0 To: gentoo-pms@lists.gentoo.org Subject: Re: [gentoo-pms] [PATCH] EAPI must be at least a single char. References: <1348993716-27744-1-git-send-email-ferringb@gmail.com> <20584.3387.660954.8184@a1i15.kph.uni-mainz.de> <20120930194455.GB2180@localhost> <5068A308.3090303@gentoo.org> <20584.49976.485460.399575@a1i15.kph.uni-mainz.de> In-Reply-To: <20584.49976.485460.399575@a1i15.kph.uni-mainz.de> X-Enigmail-Version: 1.4.4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Archives-Salt: d5e9ce48-1a7e-4cd2-baf1-e953aaeca1cf X-Archives-Hash: 74927add39f54daaee11170b6c718185 On 09/30/2012 03:10 PM, Ulrich Mueller wrote: >>>>>> On Sun, 30 Sep 2012, Zac Medico wrote: > >>> tries to write a PM, likely fucking that up. If what you were >>> saying was the actual intention behind it, that assignment would've >>> just been along the lines of EAPI=("[^"]*"|'[^']*'|[^\t ]); aka >>> "here's how you grab what looks like an EAPI assignment". > >> I would have preferred a regex that just matches any assignment like >> this, but didn't feel like bikeshedding it, > > I doesn't really matter what the regexp is, as long as it matches a > superset of the allowed EAPI syntax. Unknown or invalid EAPIs that the > regexp doesn't match will still be rejected, because the results from > parsing and from sourcing the ebuild don't agree. > > And it is practically impossible to find a regexp that would match all > valid bash assignments. You would have to handle backslash escapes, > dollar signs, and whatnot. Still, it might make sense to replace ([A-Za-z0-9+_.-]*) with (.*), since that should work fine in practice. The spec is fine with me as it is, but I don't think a change like this would hurt. -- Thanks, Zac