Re: [gentoo-pms] [PATCH] EAPI must be at least a single char.

[Zac Medico <zmedico@gentoo.org>]

On 09/30/2012 03:10 PM, Ulrich Mueller wrote:
>>>>>> On Sun, 30 Sep 2012, Zac Medico wrote:
> 
>>> tries to write a PM, likely fucking that up.  If what you were
>>> saying was the actual intention behind it, that assignment would've
>>> just been along the lines of EAPI=("[^"]*"|'[^']*'|[^\t ]); aka
>>> "here's how you grab what looks like an EAPI assignment".
> 
>> I would have preferred a regex that just matches any assignment like
>> this, but didn't feel like bikeshedding it,
> 
> I doesn't really matter what the regexp is, as long as it matches a
> superset of the allowed EAPI syntax. Unknown or invalid EAPIs that the
> regexp doesn't match will still be rejected, because the results from
> parsing and from sourcing the ebuild don't agree.
> 
> And it is practically impossible to find a regexp that would match all
> valid bash assignments. You would have to handle backslash escapes,
> dollar signs, and whatnot.

Still, it might make sense to replace ([A-Za-z0-9+_.-]*) with (.*),
since that should work fine in practice. The spec is fine with me as it
is, but I don't think a change like this would hurt.
-- 
Thanks,
Zac