Re: [gentoo-pms] [PATCH 5/6] *into, *opts: Clarify the number of arguments

[Ulrich Mueller <ulm@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1802 bytes --]

>>>>> On Tue, 1 May 2018, Michał Górny wrote:

> Clarify the number of arguments taken by *into and *opts.  The former
> always takes a single argument, so clarify that calling it without
> arguments is invalid.  The latter may take 0+ arguments (with 0
> resetting the list), so clarify that the correct way is to pass multiple
> arguments rather than a single quoted argument.
> ---
>  pkg-mgr-commands.tex | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)

> diff --git a/pkg-mgr-commands.tex b/pkg-mgr-commands.tex
> index 6bb06ca..ad64ad1 100644
> --- a/pkg-mgr-commands.tex
> +++ b/pkg-mgr-commands.tex
> @@ -715,8 +715,9 @@ has returned.
 
>  \begin{description}
 
> -\item[into] Sets the value of \t{DESTTREE} for future invocations
> -    of the above utilities. Creates the directory under \t{\$\{ED\}}
> +\item[into] Takes exactly one argument, and sets the value of \t{DESTTREE}
> +    for future invocations of the above utilities to it.
> +    Creates the directory under \t{\$\{ED\}}

Please rewrap to 100 characters.

>      in offset-prefix aware EAPIs or under \t{\$\{D\}} in offset-prefix
>      agnostic EAPIs, using \t{install -d} with no additional options,
>      if it does not already exist. Failure behaviour is EAPI dependent
> @@ -728,7 +729,9 @@ has returned.
 
>  \item[docinto] As \t{into}, for install subdirectory of \t{dodoc} et al.
 
> -\item[insopts] Sets the options passed by \t{doins} et al.\ to the \t{install} command.
> +\item[insopts] Takes zero or more arguments, and sets the options passed by \t{doins} et al.
> +    to the \t{install} command to them. When called with no arguments, resets the option list
> +    to empty.
 
>  \item[diropts] As \t{insopts}, for \t{dodir} et al.
 
> -- 
> 2.17.0

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]