Re: [gentoo-pms] [PATCH 2/6] best_version: Explicitly specify the output format

[Ulrich Mueller <ulm@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1425 bytes --]

>>>>> On Tue, 1 May 2018, Michał Górny wrote:

> Explain the format used by best_version command explicitly.  Currently,
> the function only lists what gets printed but not in what form or how it
> is separated.
> ---
>  pkg-mgr-commands.tex | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

> diff --git a/pkg-mgr-commands.tex b/pkg-mgr-commands.tex
> index cb704f0..4299624 100644
> --- a/pkg-mgr-commands.tex
> +++ b/pkg-mgr-commands.tex
> @@ -105,8 +105,9 @@ are given, \t{-r} is assumed.
>  \item[has_version] Takes exactly one package dependency specification as an argument. Returns
>      true if a package matching the specification is installed, and false otherwise.
>  \item[best_version] Takes exactly one package dependency specification as an argument. If a
> -    matching package is installed, prints the category, package name and version of the highest
> -    matching version; otherwise, prints an empty string. The exit code is unspecified.
> +    matching package is installed, prints the category, followed by \t{/}, followed by package
> +    name, followed by \t{-}, followed by full version of the highest matching version;

Do we really need this? I think that "category, package name and
version" is pretty clear.

> +    otherwise, prints an empty string. The exit code is unspecified.
>  \end{description}
 
>  \ChangeWhenAddingAnEAPI{7}
> -- 
> 2.17.0

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]