[gentoo-pms] [PATCH v2] pkg-mgr-commands: Add --build and --target to econf (retroactively)

[gentoo-pms] [PATCH v2] pkg-mgr-commands: Add --build and --target to econf (retroactively)

[Michał Górny]

Amend the econf parameter list with --build and --target options
corresponding to CBUILD and CTARGET variables respectively. They are
useful for cross-compilation purposes (whose support is improved
in EAPI 7), and all three package managers have been passing them dating
back at least to 2005 and/or their inception appropriately.
---
 appendices.tex       | 6 ++++++
 pkg-mgr-commands.tex | 5 +++++
 2 files changed, 11 insertions(+)

diff --git a/appendices.tex b/appendices.tex
index 434aa3f..e9e0fd5 100644
--- a/appendices.tex
+++ b/appendices.tex
@@ -110,6 +110,12 @@ all-of, any-of, exactly-one-of, at-most-one-of and use-conditional groups with z
 However, such empty groups were neither supported by all package managers nor used in ebuilds.
 They were dropped from the specification in October 2017.
 
+\subsection{-{}-build and -{}-target econf parameters}
+The \t{econf} command (see section~\ref{sec:build-commands}) has been amended to include two
+additional configure options: --build and --target.  Originally those options were not included
+in the PMS, even though Portage has been passing them before 2005 already; they are also passed
+by Paludis and pkgcore.
+
 % vim: set filetype=tex fileencoding=utf8 et tw=100 spell spelllang=en :
 
 %%% Local Variables:
diff --git a/pkg-mgr-commands.tex b/pkg-mgr-commands.tex
index 9a80370..f57e645 100644
--- a/pkg-mgr-commands.tex
+++ b/pkg-mgr-commands.tex
@@ -233,6 +233,7 @@ Ebuilds must not run any of these commands once the current phase function has r
 \end{centertable}
 
 \subsection{Build commands}
+\label{sec:build-commands}
 These commands are used during the \t{src_configure}, \t{src_compile}, and \t{src_install}
 phases to run the package's build commands. Ebuilds must not run any of these commands once the
 current phase function has returned.
@@ -258,7 +259,11 @@ current phase function has returned.
     \item -{}-htmldir must be \t{\$\{EPREFIX\}/usr/share/doc/\$\{PF\}/html}, if the EAPI is listed
         in table~\ref{tab:econf-options-table} as using it. This option will only be passed if the
         string \t{-{}-htmldir} occurs in the output of \t{configure -{}-help}.
+    \item -{}-build must be the value of the \t{CBUILD} environment variable. This option will only
+        be passed if the \t{CBUILD} variable is set to a non-empty value.
     \item -{}-host must be the value of the \t{CHOST} environment variable.
+    \item -{}-target must be the value of the \t{CTARGET} environment variable. This option will only
+        be passed if the \t{CTARGET} variable is set to a non-empty value.
     \item -{}-libdir must be set according to Algorithm~\ref{alg:econf-libdir}.
     \item -{}-disable-dependency-tracking, if the EAPI is listed in
         table~\ref{tab:econf-options-table} as using it. This option will only be passed if the
-- 
2.16.1

Re: [gentoo-pms] [PATCH v2] pkg-mgr-commands: Add --build and --target to econf (retroactively)

[Ulrich Mueller]

[-- Attachment #1: Type: text/plain, Size: 1071 bytes --]

>>>>> On Sat, 17 Feb 2018, Michał Górny wrote:

> +\subsection{-{}-build and -{}-target econf parameters}
> +The \t{econf} command (see section~\ref{sec:build-commands}) has been amended to include two
> +additional configure options: --build and --target.  Originally those options were not included
> +in the PMS, even though Portage has been passing them before 2005 already; they are also passed
> +by Paludis and pkgcore.

This is a bit redundant: If it has been amended then it is clear that
it wasn't present before. I'd just start the second sentence with:
"Portage has been passing both options ..."

> +    \item -{}-build must be the value of the \t{CBUILD} environment variable. This option will only
> +        be passed if the \t{CBUILD} variable is set to a non-empty value.

Maybe shorten this to: "... if \t{CBUILD} is non-empty."

> +    \item -{}-target must be the value of the \t{CTARGET} environment variable. This option will only
> +        be passed if the \t{CTARGET} variable is set to a non-empty value.

Ditto.

Ulrich

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: [gentoo-pms] [PATCH v2] pkg-mgr-commands: Add --build and --target to econf (retroactively)

[Ulrich Mueller]

[-- Attachment #1: Type: text/plain, Size: 1001 bytes --]

>>>>> On Sat, 17 Feb 2018, Ulrich Mueller wrote:

>>>>> On Sat, 17 Feb 2018, Michał Górny wrote:
>> +\subsection{-{}-build and -{}-target econf parameters}
>> +The \t{econf} command (see section~\ref{sec:build-commands}) has been amended to include two
>> +additional configure options: --build and --target.  Originally those options were not included
>> +in the PMS, even though Portage has been passing them before 2005 already; they are also passed
>> +by Paludis and pkgcore.

> This is a bit redundant: If it has been amended then it is clear
> that it wasn't present before. I'd just start the second sentence
> with: "Portage has been passing both options ..."

Thinking about it, the section in the appendix lists only retroactive
changes that went through council approval (and says so in its
introductory paragraph). The present patch isn't a retroactive change
though, it merely updates the spec to agree with behaviour of all
three package managers in EAPI 0.

Ulrich

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]