From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-pms+bounces-1042-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by finch.gentoo.org (Postfix) with ESMTPS id DE3291382C5
	for <garchives@archives.gentoo.org>; Sat, 17 Feb 2018 11:38:17 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 0832FE08DB;
	Sat, 17 Feb 2018 11:38:17 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id C4391E08DB
	for <gentoo-pms@lists.gentoo.org>; Sat, 17 Feb 2018 11:38:16 +0000 (UTC)
Received: from a1i15.kph.uni-mainz.de (host2092.kph.uni-mainz.de [134.93.134.92])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	(Authenticated sender: ulm)
	by smtp.gentoo.org (Postfix) with ESMTPSA id D2642335C2C;
	Sat, 17 Feb 2018 11:38:14 +0000 (UTC)
Message-ID: <23176.5154.802025.314215@a1i15.kph.uni-mainz.de>
Date: Sat, 17 Feb 2018 12:38:10 +0100
To: gentoo-pms@lists.gentoo.org
Cc: =?iso-8859-2?Q?Micha=B3_G=F3rny?= <mgorny@gentoo.org>
Subject: Re: [gentoo-pms] [PATCH eapi-7] EAPI 7: econf passes --build.
In-Reply-To: <20180217091813.14206-1-mgorny@gentoo.org>
References: <20180217091813.14206-1-mgorny@gentoo.org>
X-Mailer: VM 8.2.0b under 24.3.1 (x86_64-pc-linux-gnu)
From: Ulrich Mueller <ulm@gentoo.org>
Precedence: bulk
List-Post: <mailto:gentoo-pms@lists.gentoo.org>
List-Help: <mailto:gentoo-pms+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-pms+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-pms+subscribe@lists.gentoo.org>
List-Id: Gentoo Package Manager Specification discussions <gentoo-pms.gentoo.org>
X-BeenThere: gentoo-pms@gentoo.org
X-BeenThere: gentoo-pms@lists.gentoo.org
Reply-To: gentoo-pms@lists.gentoo.org
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="pgp+signed+OqFpXV3kJkajQX9";
	micalg=pgp-sha256; protocol="application/pgp-signature"
X-Archives-Salt: 42cd203c-1460-42cc-9cba-5fbbc6599e18
X-Archives-Hash: 03b0ece9adcb07504edd2ba44bd2f030

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--pgp+signed+OqFpXV3kJkajQX9
Content-Type: text/plain; charset=iso-8859-2
Content-Transfer-Encoding: quoted-printable

>>>>> On Sat, 17 Feb 2018, Micha=B3 G=F3rny wrote:

> --- a/pkg-mgr-commands.tex
> +++ b/pkg-mgr-commands.tex
> @@ -340,6 +340,9 @@ current phase function has returned.
>      \item -{}-with-sysroot must be \t{\$\{ESYSROOT\}}, if the EAPI i=
s listed in
>          table~\ref{tab:econf-options-table} as using it. This option=
 will only be passed if the
>          string \t{-{}-with-sysroot} occurs in the output of \t{confi=
gure -{}-help}.
> +    \item -{}-build must be the value of the \t{CBUILD} environment =
variable, if the EAPI is listed
> +        table~\ref{tab:econf-options-table} as using it. This option=
 will only be passed if the

s/table/in table/

> +        \t{CBUILD} variable is set to a non-empty value.
>      \item -{}-host must be the value of the \t{CHOST} environment va=
riable.
>      \item -{}-libdir must be set according to Algorithm~\ref{alg:eco=
nf-libdir}.
>      \item -{}-disable-dependency-tracking, if the EAPI is listed in
> @@ -353,20 +356,21 @@ current phase function has returned.
>      \ChangeWhenAddingAnEAPI{7}
>      \begin{centertable}{Extra \t{econf} arguments for EAPIs}
>          \label{tab:econf-options-table}
> -        \begin{tabular}{llllll}
> +        \begin{tabular}{lllllll}
>            \toprule
>            \multicolumn{1}{c}{\textbf{EAPI}} &
> -          \multicolumn{1}{P{9em}}{\textbf{-{}-disable-dependency-tra=
cking}} &
> +          \multicolumn{1}{P{5em}}{\textbf{-{}-disable-dependency-tra=
cking}} &

This causes an overfull box. Rather leave it at 9em (which will also
save a line) but change --with-sysroot below to P{3em}.

>            \multicolumn{1}{P{5em}}{\textbf{-{}-disable-silent-rules}}=
 &
>            \multicolumn{1}{c}{\textbf{-{}-docdir}} &
>            \multicolumn{1}{c}{\textbf{-{}-htmldir}} &
> -          \multicolumn{1}{c}{\textbf{-{}-with-sysroot}} \\
> +          \multicolumn{1}{c}{\textbf{-{}-with-sysroot}} &
> +          \multicolumn{1}{c}{\textbf{-{}-build}} \\
>            \midrule
> -          0, 1, 2, 3        & No  & No  & No  & No  & No  \\
> -          4                 & Yes & No  & No  & No  & No  \\
> -          5                 & Yes & Yes & No  & No  & No  \\
> -          6                 & Yes & Yes & Yes & Yes & No  \\
> -          7                 & Yes & Yes & Yes & Yes & Yes \\
> +          0, 1, 2, 3        & No  & No  & No  & No  & No  & No  \\
> +          4                 & Yes & No  & No  & No  & No  & No  \\
> +          5                 & Yes & Yes & No  & No  & No  & No  \\
> +          6                 & Yes & Yes & Yes & Yes & No  & No  \\
> +          7                 & Yes & Yes & Yes & Yes & Yes & Yes \\
>            \bottomrule
>          \end{tabular}
>      \end{centertable}

Otherwise LGTM.

Ulrich

--pgp+signed+OqFpXV3kJkajQX9
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQEcBAEBCAAGBQJaiBQhAAoJEMMJBoUcYcJze+wH/iAXX2ncX0S15XmNr+jXh9N0
/9CEhA4XJ9MoBIyA6DpE1bjyo/CahW3XaDhcCTLFEb+CgOggsgdT5TtaDmHnNK1q
fT9lh5gFysnlKopIaLRoundUSPpXHLD3yd2INrOwp4iVbjES77MMUjGrt6rWHWO8
mthleek8j97WaQLhO2vU2xiBX+ZrSp4mt/AMH6Mpthlbr6RwL/LmcXQuK2S6tKKq
89Lvj+Ce71y5iCN3rT/AguaXMBP+BPEKwLyjfpXroJWkvKSMCvsvaybNaxyj8FGn
BACuL9nheD6sxadJf3IrAF1tRiHTefaH94HoTMtc1v5ucpvMoNggrEsj86miJ0Q=
=++cy
-----END PGP SIGNATURE-----

--pgp+signed+OqFpXV3kJkajQX9--