[gentoo-pms] [PATCH] Fix typos in strings occurring in configure --help output.

[gentoo-pms] [PATCH] Fix typos in strings occurring in configure --help output.

[Ulrich Müller]

These should be "--disable-dependency-tracking" and
"--disable-silent-rules", respectively (note the leading "--").
---
 pkg-mgr-commands.tex | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/pkg-mgr-commands.tex b/pkg-mgr-commands.tex
index 5fd3d62..ef65d0c 100644
--- a/pkg-mgr-commands.tex
+++ b/pkg-mgr-commands.tex
@@ -180,10 +180,10 @@ has returned.
     \item -{}-libdir must be set according to Algorithm~\ref{alg:econf-libdir}.
     \item -{}-disable-dependency-tracking, if the EAPI is listed in
         table~\ref{tab:econf-options-table} as using it. This option will only be passed if the
-        string \t{disable-dependency-tracking} occurs in the output of \t{configure -{}-help}.
-    \item -{}-disable-silent-rules, if the EAPI is listed in
-        table~\ref{tab:econf-options-table} as using it. This option will only be passed if the
-        string \t{disable-silent-rules} occurs in the output of \t{configure -{}-help}.
+        string \t{-{}-disable-dependency-tracking} occurs in the output of \t{configure -{}-help}.
+    \item -{}-disable-silent-rules, if the EAPI is listed in table~\ref{tab:econf-options-table} as
+        using it. This option will only be passed if the string \t{-{}-disable-silent-rules} occurs
+        in the output of \t{configure -{}-help}.
     \end{itemize}
 
     \ChangeWhenAddingAnEAPI{6}
-- 
2.3.0

Re: [gentoo-pms] [PATCH] Fix typos in strings occurring in configure --help output.

[David Leverton]

Ulrich Müller wrote:
> These should be "--disable-dependency-tracking" and
> "--disable-silent-rules", respectively (note the leading "--").

The original implementation for --disable-dependency-tracking in Portage 
really did check without the "--", but it was changed in
7d7387b (2012-08-29) at the same time that --disable-silent-rules was 
added.  Paludis follows the spec as it currently is and doesn't include 
the "--".  As this is such a small detail I'm not going to complain too 
much, but technically it is a retroactive change....

Re: [gentoo-pms] [PATCH] Fix typos in strings occurring in configure --help output.

[Ulrich Mueller]

[-- Attachment #1: Type: text/plain, Size: 1280 bytes --]

>>>>> On Mon, 16 Feb 2015, David Leverton wrote:

> The original implementation for --disable-dependency-tracking in
> Portage really did check without the "--", but it was changed in
> 7d7387b (2012-08-29) at the same time that --disable-silent-rules
> was added. Paludis follows the spec as it currently is and doesn't
> include the "--". As this is such a small detail I'm not going to
> complain too much, but technically it is a retroactive change....

I don't remember why we don't include the "--", but the earlist
mention of it seems to be this:
https://bugs.gentoo.org/show_bug.cgi?id=211529#c24
(I suspect that it was omitted simply because grepping for a string
starting with a hyphen is slightly more complicated ...)

Anyway, Portage includes the "--" since some time and there seem to be
no issues with it. More importantly, EAPI 6 will have --docdir and
--htmldir, and I fear that matching them without the "--" might lead
to false positives.

So our choices are a) inconsistent behaviour for EAPI 6, matching
"disable-silent-rules" but "--docdir", b) a complicated spec with
"disable-silent-rules" in EAPI 5 (and not matching Portage behaviour)
but "--disable-silent-rules" in EAPI 6, or c) a small retroactive
change. To me c) looks like the lesser evil.

Ulrich

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

[gentoo-pms] Re: [PATCH] Fix typos in strings occurring in configure --help output.

[Ulrich Mueller]

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

>>>>> On Mon, 16 Feb 2015, Ulrich Müller wrote:

> These should be "--disable-dependency-tracking" and
> "--disable-silent-rules", respectively (note the leading "--").

Pushed to master.

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]