public inbox for gentoo-pms@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-pms] [PATCH] src-install-4: Replace single quotes by double quotes
@ 2012-11-28  9:24 Ulrich Mueller
  0 siblings, 0 replies; only message in thread
From: Ulrich Mueller @ 2012-11-28  9:24 UTC (permalink / raw
  To: gentoo-pms

Apparently it's possible to confuse the single quotes in the EAPI 4
src_install implementation with backquotes. This has made it into the
devmanual and into at least one eclass. See bug 444832.

Can we replace the single quotes by double quotes? For bash it doesn't
make any difference.

Ulrich


From 6cc58a14e8f8d9d7b98bc58c115cd58c2d898544 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ulrich=20M=C3=BCller?= <ulm@gentoo.org>
Date: Wed, 28 Nov 2012 10:18:00 +0100
Subject: [PATCH] src-install-4: Replace single quotes by double quotes

This improves readability. It doesn't make any difference for bash.
---
 ebuild-functions.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ebuild-functions.tex b/ebuild-functions.tex
index 1f2ab68..84847e9 100644
--- a/ebuild-functions.tex
+++ b/ebuild-functions.tex
@@ -317,7 +317,7 @@ src_install() {
                 THANKS BUGS FAQ CREDITS CHANGELOG ; do
             [[ -s "${d}" ]] && dodoc "${d}"
         done
-    elif declare -p DOCS | grep -q '^declare -a ' ; then
+    elif declare -p DOCS | grep -q "^declare -a " ; then
         dodoc "${DOCS[@]}"
     else
         dodoc ${DOCS}
-- 
1.8.0



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2012-11-28  9:25 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-28  9:24 [gentoo-pms] [PATCH] src-install-4: Replace single quotes by double quotes Ulrich Mueller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox