From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 914A8138010 for ; Mon, 1 Oct 2012 00:08:56 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 87C5D21C0A5 for ; Mon, 1 Oct 2012 00:08:54 +0000 (UTC) Received: from a1iwww1.kph.uni-mainz.de (a1iwww1.kph.uni-mainz.de [134.93.134.1]) by pigeon.gentoo.org (Postfix) with ESMTP id 4DC0121C08F for ; Sun, 30 Sep 2012 22:10:02 +0000 (UTC) Received: from a1i15.kph.uni-mainz.de (a1i15.kph.uni-mainz.de [134.93.134.92]) by a1iwww1.kph.uni-mainz.de (8.14.4/8.13.4) with ESMTP id q8UMA0qc025507 for ; Mon, 1 Oct 2012 00:10:00 +0200 Received: from a1i15.kph.uni-mainz.de (localhost [127.0.0.1]) by a1i15.kph.uni-mainz.de (8.14.5/8.14.2) with ESMTP id q8UMA0k0010346; Mon, 1 Oct 2012 00:10:00 +0200 Received: (from ulm@localhost) by a1i15.kph.uni-mainz.de (8.14.5/8.14.5/Submit) id q8UMA0Z5010342; Mon, 1 Oct 2012 00:10:00 +0200 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Package Manager Specification discussions X-BeenThere: gentoo-pms@gentoo.org X-BeenThere: gentoo-pms@lists.gentoo.org Reply-To: gentoo-pms@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <20584.49976.485460.399575@a1i15.kph.uni-mainz.de> Date: Mon, 1 Oct 2012 00:10:00 +0200 To: gentoo-pms@lists.gentoo.org Subject: Re: [gentoo-pms] [PATCH] EAPI must be at least a single char. In-Reply-To: <5068A308.3090303@gentoo.org> References: <1348993716-27744-1-git-send-email-ferringb@gmail.com> <20584.3387.660954.8184@a1i15.kph.uni-mainz.de> <20120930194455.GB2180@localhost> <5068A308.3090303@gentoo.org> X-Mailer: VM 8.2.0b under 23.4.2 (x86_64-pc-linux-gnu) From: Ulrich Mueller X-Archives-Salt: 450d9cca-a45f-4fcb-a82a-629e99d51c01 X-Archives-Hash: c600c1fcd39310e42891f22428111570 >>>>> On Sun, 30 Sep 2012, Zac Medico wrote: >> tries to write a PM, likely fucking that up. If what you were >> saying was the actual intention behind it, that assignment would've >> just been along the lines of EAPI=("[^"]*"|'[^']*'|[^\t ]); aka >> "here's how you grab what looks like an EAPI assignment". > I would have preferred a regex that just matches any assignment like > this, but didn't feel like bikeshedding it, I doesn't really matter what the regexp is, as long as it matches a superset of the allowed EAPI syntax. Unknown or invalid EAPIs that the regexp doesn't match will still be rejected, because the results from parsing and from sourcing the ebuild don't agree. And it is practically impossible to find a regexp that would match all valid bash assignments. You would have to handle backslash escapes, dollar signs, and whatnot. > since the one that's currently in the spec works in practice. Exactly. Ulrich