[gentoo-pms] Mention xargs?

[gentoo-pms] Mention xargs?

[Ulrich Mueller]

When preparing the list of EAPI 5 features for the upcoming council
meeting, I noticed that the eapi-5 branch mentions only GNU find [1]
whereas the corresponding bug mentions both find and xargs [2].

Shouldn't we mention xargs, too?

Ulrich

[1] <http://git.overlays.gentoo.org/gitweb/?p=proj/pms.git;a=commit;h=472690942e14f63f1b1f3a5681976a59539ea3f8>
[2] <https://bugs.gentoo.org/show_bug.cgi?id=384157#c2>

From f9741fb09b19bb0cf232254368617c31f3c22898 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ulrich=20M=C3=BCller?= <ulm@gentoo.org>
Date: Sun, 12 Aug 2012 10:55:51 +0200
Subject: [PATCH] Require xargs in addition to find.

---
 ebuild-env-commands.tex |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/ebuild-env-commands.tex b/ebuild-env-commands.tex
index 1129fa6..d24fc81 100644
--- a/ebuild-env-commands.tex
+++ b/ebuild-env-commands.tex
@@ -29,8 +29,8 @@ The following commands must always be available in the ebuild environment:
 \item \t{sed} must be available, and must support all forms of invocations valid for GNU sed
     version 4 or later.
 \item \t{patch} must be available, and must support all inputs valid for GNU patch.
-\item \t{find} must be available, and must support all forms of invocations valid for GNU find
-    version 4.4 or later. Only for EAPIs listed in table~\ref{tab:system-commands-table} as
+\item \t{find} and \t{xargs} must be available, and must support all forms of invocations valid for
+    GNU find version 4.4 or later. Only for EAPIs listed in table~\ref{tab:system-commands-table} as
     requiring GNU find. \featurelabel{gnu-find}
 \end{compactitem}
 
-- 
1.7.8.6

Re: [gentoo-pms] Mention xargs?

[Ralph Sennhauser]

On Sun, 12 Aug 2012 10:56:02 +0200
Ulrich Mueller <ulm@gentoo.org> wrote:

> When preparing the list of EAPI 5 features for the upcoming council
> meeting, I noticed that the eapi-5 branch mentions only GNU find [1]
> whereas the corresponding bug mentions both find and xargs [2].
> 
> Shouldn't we mention xargs, too?

Usually I see xargs used as 'find <somestuff> | xargs <dosomething>'
which can easily be handled by find alone. So, not sure we want to
mandate xargs at all.

> 
> Ulrich
> 
> [1]
> <http://git.overlays.gentoo.org/gitweb/?p=proj/pms.git;a=commit;h=472690942e14f63f1b1f3a5681976a59539ea3f8>
> [2] <https://bugs.gentoo.org/show_bug.cgi?id=384157#c2>
> 
> From f9741fb09b19bb0cf232254368617c31f3c22898 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Ulrich=20M=C3=BCller?= <ulm@gentoo.org>
> Date: Sun, 12 Aug 2012 10:55:51 +0200
> Subject: [PATCH] Require xargs in addition to find.
> 
> ---
>  ebuild-env-commands.tex |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ebuild-env-commands.tex b/ebuild-env-commands.tex
> index 1129fa6..d24fc81 100644
> --- a/ebuild-env-commands.tex
> +++ b/ebuild-env-commands.tex
> @@ -29,8 +29,8 @@ The following commands must always be available in
> the ebuild environment: \item \t{sed} must be available, and must
> support all forms of invocations valid for GNU sed version 4 or later.
>  \item \t{patch} must be available, and must support all inputs valid
> for GNU patch. -\item \t{find} must be available, and must support
> all forms of invocations valid for GNU find
> -    version 4.4 or later. Only for EAPIs listed in
> table~\ref{tab:system-commands-table} as +\item \t{find} and
> \t{xargs} must be available, and must support all forms of
> invocations valid for
> +    GNU find version 4.4 or later. Only for EAPIs listed in
> table~\ref{tab:system-commands-table} as requiring GNU find.
> \featurelabel{gnu-find} \end{compactitem}
>  

Re: [gentoo-pms] Mention xargs?

[Ulrich Mueller]

>>>>> On Sun, 12 Aug 2012, Ralph Sennhauser wrote:

>> When preparing the list of EAPI 5 features for the upcoming council
>> meeting, I noticed that the eapi-5 branch mentions only GNU find
>> [1] whereas the corresponding bug mentions both find and xargs [2].
>> 
>> Shouldn't we mention xargs, too?

> Usually I see xargs used as 'find <somestuff> | xargs <dosomething>'
> which can easily be handled by find alone. So, not sure we want to
> mandate xargs at all.

Well, xargs is mandated by POSIX, so it will be present in the system
anyway. So we'd better make sure that the implementations of find and
xargs match.

This would also agree with current practice. For example, the
following is done in profiles/default/bsd/fbsd/profile.bashrc:

   type -P gfind > /dev/null && alias find=gfind
   type -P gxargs > /dev/null && alias xargs=gxargs

Another small issue, the package isn't named "find" but "findutils":
<http://git.overlays.gentoo.org/gitweb/?p=proj/pms.git;a=commit;h=6a95dae3fa6b8a6307f5d02c09dc550f1fbe97f2>

Ulrich

Re: [gentoo-pms] Mention xargs?

[Ralph Sennhauser]

On Tue, 14 Aug 2012 08:07:15 +0200
Ulrich Mueller <ulm@gentoo.org> wrote:

> >>>>> On Sun, 12 Aug 2012, Ralph Sennhauser wrote:
> 
> >> When preparing the list of EAPI 5 features for the upcoming council
> >> meeting, I noticed that the eapi-5 branch mentions only GNU find
> >> [1] whereas the corresponding bug mentions both find and xargs [2].
> >> 
> >> Shouldn't we mention xargs, too?
> 
> > Usually I see xargs used as 'find <somestuff> | xargs <dosomething>'
> > which can easily be handled by find alone. So, not sure we want to
> > mandate xargs at all.
> 
> Well, xargs is mandated by POSIX, so it will be present in the system
> anyway. So we'd better make sure that the implementations of find and
> xargs match.
> 
> This would also agree with current practice. For example, the
> following is done in profiles/default/bsd/fbsd/profile.bashrc:
> 
>    type -P gfind > /dev/null && alias find=gfind
>    type -P gxargs > /dev/null && alias xargs=gxargs
> 
> Another small issue, the package isn't named "find" but "findutils":
> <http://git.overlays.gentoo.org/gitweb/?p=proj/pms.git;a=commit;h=6a95dae3fa6b8a6307f5d02c09dc550f1fbe97f2>
> 
> Ulrich
> 

I see where you are coming from, however, the first thing that comes to
mind is, there should be a paragraph in the devmanual "useless use of
xargs" as there is for cat.

Ralph

Re: [gentoo-pms] Mention xargs?

[Ulrich Mueller]

>>>>> On Sat, 18 Aug 2012, Ralph Sennhauser wrote:

> I see where you are coming from, however, the first thing that comes
> to mind is, there should be a paragraph in the devmanual "useless
> use of xargs" as there is for cat.

First the section about find should be fixed, which mentions only
"find -exec ;" but neither "find -exec +" nor "find -delete".

Ulrich

[gentoo-pms] Re: Mention xargs?

[Ulrich Mueller]

Committed to eapi-5 branch:
<http://git.overlays.gentoo.org/gitweb/?p=proj/pms.git;a=commit;h=421f2b9ae05999d621eb663f263ca93eaad0ae57>

Ulrich