public inbox for gentoo-pms@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-pms] dolib description misses DESTTREE
@ 2012-01-05 18:05 Ulrich Mueller
  2012-01-27 16:29 ` [gentoo-pms] Clarifications on dosym behaviour Ralph Sennhauser
  0 siblings, 1 reply; 4+ messages in thread
From: Ulrich Mueller @ 2012-01-05 18:05 UTC (permalink / raw
  To: gentoo-pms

In the "Installation commands" section, the description of dolib
doesn't mention DESTTREE. Patch is included below, please review.

Ulrich


From 3c2730e1cc1cc31df61ed7fe4598a68dbd375444 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ulrich=20M=C3=BCller?= <ulm@gentoo.org>
Date: Thu, 5 Jan 2012 18:52:32 +0100
Subject: [PATCH] dolib: Mention DESTTREE.

dolib installs the libraries listed in its arguments in a subdirectory
of DESTTREE.
---
 pkg-mgr-commands.tex |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/pkg-mgr-commands.tex b/pkg-mgr-commands.tex
index 724281d..f278e19 100644
--- a/pkg-mgr-commands.tex
+++ b/pkg-mgr-commands.tex
@@ -306,11 +306,11 @@ that can be passed to \t{dohtml} are as follows:
     for other EAPIs, behaviour is undefined if any symlink is encountered. Failure
     behaviour is EAPI dependent as per section~\ref{sec:failure-behaviour}.
 
-\item[dolib] For each argument, installs it into the appropriate library directory as determined by
-    Algorithm~\ref{alg:ebuild-libdir}, by default with file mode \t{0644}. This can be overridden by
-    setting \t{LIBOPTIONS} with the \t{libopts} function. Any symlinks are installed into the same
-    directory as relative links to their original target. Failure behaviour is EAPI dependent as per
-    section~\ref{sec:failure-behaviour}.
+\item[dolib] For each argument, installs it into the appropriate library subdirectory under
+    \t{DESTTREE}, as determined by Algorithm~\ref{alg:ebuild-libdir}. The file mode is \t{0644}
+    by default. This can be overridden by setting \t{LIBOPTIONS} with the \t{libopts} function.
+    Any symlinks are installed into the same directory as relative links to their original target.
+    Failure behaviour is EAPI dependent as per section~\ref{sec:failure-behaviour}.
 
 \item[dolib.so] As for dolib except each file is installed with mode \t{0755}.
 
-- 
1.7.8.2



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [gentoo-pms] Clarifications on dosym behaviour
  2012-01-05 18:05 [gentoo-pms] dolib description misses DESTTREE Ulrich Mueller
@ 2012-01-27 16:29 ` Ralph Sennhauser
  2012-01-27 19:23   ` Ulrich Mueller
  0 siblings, 1 reply; 4+ messages in thread
From: Ralph Sennhauser @ 2012-01-27 16:29 UTC (permalink / raw
  To: gentoo-pms

Just recently Portage started to emit "* QA Notice: dosym target omits
basename ..." for "dosym /path_to_file/file /some_other_path/"

The PMS says:

dosym: Creates a symbolic link named as for its second parameter,
pointing to the first. If the directory containing the new link does
not exist, creates it. Failure behaviour is EAPI dependent as per
section 12.3.3.1.

The part "Creates a symbolic link named as for its second parameter"
could qualify it for requiring a basename.

As the behaviour of an implicit basename of the second parameter was
used for a long time I wonder if the PMS needs to be updated and clarify
the dosym behaviour or if this new QA warning can be seen as a long
overdue implementation of the intended behaviour.

Thanks.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [gentoo-pms] Clarifications on dosym behaviour
  2012-01-27 16:29 ` [gentoo-pms] Clarifications on dosym behaviour Ralph Sennhauser
@ 2012-01-27 19:23   ` Ulrich Mueller
  2012-01-27 21:59     ` Ralph Sennhauser
  0 siblings, 1 reply; 4+ messages in thread
From: Ulrich Mueller @ 2012-01-27 19:23 UTC (permalink / raw
  To: gentoo-pms

>>>>> On Fri, 27 Jan 2012, Ralph Sennhauser wrote:

> Just recently Portage started to emit "* QA Notice: dosym target
> omits basename ..." for "dosym /path_to_file/file /some_other_path/"

> The PMS says:

> dosym: Creates a symbolic link named as for its second parameter,
> pointing to the first. If the directory containing the new link does
> not exist, creates it. Failure behaviour is EAPI dependent as per
> section 12.3.3.1.

> The part "Creates a symbolic link named as for its second parameter"
> could qualify it for requiring a basename.

Exactly.

> As the behaviour of an implicit basename of the second parameter was
> used for a long time I wonder if the PMS needs to be updated and
> clarify the dosym behaviour or if this new QA warning can be seen as
> a long overdue implementation of the intended behaviour.

This has been discussed in bug 379899 and the conclusion was that PMS
specifies the intended behaviour.

At the moment a directory argument produces only a QA warning in
Portage. I think the long-term plan is to turn it into an error
though.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [gentoo-pms] Clarifications on dosym behaviour
  2012-01-27 19:23   ` Ulrich Mueller
@ 2012-01-27 21:59     ` Ralph Sennhauser
  0 siblings, 0 replies; 4+ messages in thread
From: Ralph Sennhauser @ 2012-01-27 21:59 UTC (permalink / raw
  To: gentoo-pms

On Fri, 27 Jan 2012 20:23:10 +0100
Ulrich Mueller <ulm@gentoo.org> wrote:

> >>>>> On Fri, 27 Jan 2012, Ralph Sennhauser wrote:
> 
> > Just recently Portage started to emit "* QA Notice: dosym target
> > omits basename ..." for "dosym /path_to_file/file /some_other_path/"
> 
> > The PMS says:
> 
> > dosym: Creates a symbolic link named as for its second parameter,
> > pointing to the first. If the directory containing the new link does
> > not exist, creates it. Failure behaviour is EAPI dependent as per
> > section 12.3.3.1.
> 
> > The part "Creates a symbolic link named as for its second parameter"
> > could qualify it for requiring a basename.
> 
> Exactly.
> 
> > As the behaviour of an implicit basename of the second parameter was
> > used for a long time I wonder if the PMS needs to be updated and
> > clarify the dosym behaviour or if this new QA warning can be seen as
> > a long overdue implementation of the intended behaviour.
> 
> This has been discussed in bug 379899 and the conclusion was that PMS
> specifies the intended behaviour.
> 
> At the moment a directory argument produces only a QA warning in
> Portage. I think the long-term plan is to turn it into an error
> though.
> 

Thanks for the clarifications.

Cheers



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-01-27 21:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-05 18:05 [gentoo-pms] dolib description misses DESTTREE Ulrich Mueller
2012-01-27 16:29 ` [gentoo-pms] Clarifications on dosym behaviour Ralph Sennhauser
2012-01-27 19:23   ` Ulrich Mueller
2012-01-27 21:59     ` Ralph Sennhauser

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox