From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 2A48A138334 for ; Fri, 8 Jun 2018 11:51:28 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 24371E083D; Fri, 8 Jun 2018 11:51:27 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id E0922E083D for ; Fri, 8 Jun 2018 11:51:26 +0000 (UTC) Received: from localhost.localdomain (d202-252.icpnet.pl [109.173.202.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 83FEC335CB1; Fri, 8 Jun 2018 11:51:24 +0000 (UTC) From: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= To: gentoo-pms@lists.gentoo.org Cc: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= Subject: [gentoo-pms] [PATCH] pkg-mgr-commands: Correct 'empty' insopts behavior to match PMs Date: Fri, 8 Jun 2018 13:51:20 +0200 Message-Id: <20180608115120.7042-1-mgorny@gentoo.org> X-Mailer: git-send-email 2.18.0.rc1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Package Manager Specification discussions X-BeenThere: gentoo-pms@gentoo.org X-BeenThere: gentoo-pms@lists.gentoo.org Reply-To: gentoo-pms@lists.gentoo.org X-Archives-Salt: 730ea23c-cc41-4bde-bcc6-91eb1d7e6861 X-Archives-Hash: 0e23a4de692ac7218bbf3cb2cc953394 My previous fix to insopts turns out twice wrong: firstly, because I did not really type what I meant, and secondly because package managers have inconsistent behavior there. Portage uses the default mode (specified by PMS) when insopts was called with no arguments or arguments forming an empty string; PkgCore and Paludis literally pass empty argument list to install. Mark the behavior as undefined to match that. --- pkg-mgr-commands.tex | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/pkg-mgr-commands.tex b/pkg-mgr-commands.tex index 01c0c6d..031638a 100644 --- a/pkg-mgr-commands.tex +++ b/pkg-mgr-commands.tex @@ -725,9 +725,8 @@ function has returned. \item[docinto] As \t{into}, for install subdirectory of \t{dodoc} et al. -\item[insopts] Takes zero or more arguments, and sets the options passed by \t{doins} et al.\ - to the \t{install} command to them. When called with no arguments, resets the option list - to empty. +\item[insopts] Takes one or more arguments, and sets the options passed by \t{doins} et al.\ + to the \t{install} command to them. Behavior upon encountering empty arguments is undefined. \item[diropts] As \t{insopts}, for \t{dodir} et al. -- 2.18.0.rc1