From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-pms@lists.gentoo.org
Cc: "Michał Górny" <mgorny@gentoo.org>
Subject: [gentoo-pms] [PATCH] pkg-mgr-commands: Correct 'empty' insopts behavior to match PMs
Date: Fri, 8 Jun 2018 13:51:20 +0200 [thread overview]
Message-ID: <20180608115120.7042-1-mgorny@gentoo.org> (raw)
My previous fix to insopts turns out twice wrong: firstly, because I did
not really type what I meant, and secondly because package managers have
inconsistent behavior there. Portage uses the default mode (specified
by PMS) when insopts was called with no arguments or arguments forming
an empty string; PkgCore and Paludis literally pass empty argument list
to install. Mark the behavior as undefined to match that.
---
pkg-mgr-commands.tex | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/pkg-mgr-commands.tex b/pkg-mgr-commands.tex
index 01c0c6d..031638a 100644
--- a/pkg-mgr-commands.tex
+++ b/pkg-mgr-commands.tex
@@ -725,9 +725,8 @@ function has returned.
\item[docinto] As \t{into}, for install subdirectory of \t{dodoc} et al.
-\item[insopts] Takes zero or more arguments, and sets the options passed by \t{doins} et al.\
- to the \t{install} command to them. When called with no arguments, resets the option list
- to empty.
+\item[insopts] Takes one or more arguments, and sets the options passed by \t{doins} et al.\
+ to the \t{install} command to them. Behavior upon encountering empty arguments is undefined.
\item[diropts] As \t{insopts}, for \t{dodir} et al.
--
2.18.0.rc1
next reply other threads:[~2018-06-08 11:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 11:51 Michał Górny [this message]
2018-06-08 12:07 ` [gentoo-pms] [PATCH] pkg-mgr-commands: Correct 'empty' insopts behavior to match PMs Ulrich Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180608115120.7042-1-mgorny@gentoo.org \
--to=mgorny@gentoo.org \
--cc=gentoo-pms@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox