public inbox for gentoo-pms@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-pms] [PATCH] note that config and info don't save state either
@ 2011-08-24 11:44 Brian Harring
  2011-08-24 11:56 ` Ciaran McCreesh
  0 siblings, 1 reply; 3+ messages in thread
From: Brian Harring @ 2011-08-24 11:44 UTC (permalink / raw
  To: gentoo-pms

Config arguably would benefit from env saving, but portage hasn't
done it afaik, ever, so we can't really go retroactive on that one.
---
 ebuild-env-state.tex |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/ebuild-env-state.tex b/ebuild-env-state.tex
index 82bf6dc..7b764f5 100644
--- a/ebuild-env-state.tex
+++ b/ebuild-env-state.tex
@@ -5,8 +5,8 @@ Exported and default scope variables are saved between functions. A non-local va
 function earlier in the call sequence must have its value preserved for later functions, including
 functions executed as part of a later uninstall.
 
-\note \t{pkg\_pretend} is \e{not} part of the normal call sequence, and does not take part in
-environment saving.
+\note \t{pkg\_pretend}, \t{pkg\_info}, \t{pkg\_config} are \e{not} part of the normal call sequence,
+thus do not take part in environment saving.
 
 Variables that were exported must remain exported in later functions; variables with default
 visibility may retain default visibility or be exported.
-- 
1.7.6




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [gentoo-pms] [PATCH] note that config and info don't save state either
  2011-08-24 11:44 [gentoo-pms] [PATCH] note that config and info don't save state either Brian Harring
@ 2011-08-24 11:56 ` Ciaran McCreesh
  2011-08-24 12:12   ` Brian Harring
  0 siblings, 1 reply; 3+ messages in thread
From: Ciaran McCreesh @ 2011-08-24 11:56 UTC (permalink / raw
  To: gentoo-pms

[-- Attachment #1: Type: text/plain, Size: 414 bytes --]

On Wed, 24 Aug 2011 04:44:15 -0700
Brian Harring <ferringb@gmail.com> wrote:
> Config arguably would benefit from env saving, but portage hasn't
> done it afaik, ever, so we can't really go retroactive on that one.

Hrm. Paludis loads the env for vdb for pkg_info (for installed things)
and for pkg_config, but doesn't write it back again afterwards. Is this
not what Portage does?

-- 
Ciaran McCreesh

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [gentoo-pms] [PATCH] note that config and info don't save state either
  2011-08-24 11:56 ` Ciaran McCreesh
@ 2011-08-24 12:12   ` Brian Harring
  0 siblings, 0 replies; 3+ messages in thread
From: Brian Harring @ 2011-08-24 12:12 UTC (permalink / raw
  To: gentoo-pms

On Wed, Aug 24, 2011 at 12:56:17PM +0100, Ciaran McCreesh wrote:
> On Wed, 24 Aug 2011 04:44:15 -0700
> Brian Harring <ferringb@gmail.com> wrote:
> > Config arguably would benefit from env saving, but portage hasn't
> > done it afaik, ever, so we can't really go retroactive on that one.
> 
> Hrm. Paludis loads the env for vdb for pkg_info (for installed things)
> and for pkg_config, but doesn't write it back again afterwards. Is this
> not what Portage does?

Doesn't save for config at the very least; actual loading, didn't 
check.  As for load, well, trojan the env to find out (5am my time, 
going back to bed, someone else can figure it out).

My inclincation is loading for info/config, saving for config, but 
portage long term behaviour here on the saving for config is likely 
going to be problematic.
~harring



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-08-24 12:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-24 11:44 [gentoo-pms] [PATCH] note that config and info don't save state either Brian Harring
2011-08-24 11:56 ` Ciaran McCreesh
2011-08-24 12:12   ` Brian Harring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox