From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1LuD7x-0000CF-9J for garchives@archives.gentoo.org; Wed, 15 Apr 2009 21:58:41 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 5762BE07FB; Wed, 15 Apr 2009 21:58:40 +0000 (UTC) Received: from mo-p05-ob.rzone.de (mo-p05-ob.rzone.de [81.169.146.181]) by pigeon.gentoo.org (Postfix) with ESMTP id F31DBE020C for ; Wed, 15 Apr 2009 21:58:39 +0000 (UTC) X-RZG-AUTH: :K2kKYU+nW/MMMlTokcN5Yot1/Bj/FTl+WviP6RIJci0HRMpbh/x+X6ShOQvVOjw+sRFUfkIHJ9TO X-RZG-CLASS-ID: mo05 Received: from terra.solaris (p57A4EFCD.dip.t-dialin.net [87.164.239.205]) by post.strato.de (klopstock mo25) (RZmta 18.28) with ESMTP id 204ac7l3FKf8k5 ; Wed, 15 Apr 2009 23:58:38 +0200 (MEST) Date: Wed, 15 Apr 2009 23:58:22 +0200 From: Christian Faulhammer To: Ciaran McCreesh Cc: gentoo-pms@lists.gentoo.org Subject: Re: [gentoo-pms] Patches for your reviewing pleasure: Various improvements, including cheat sheet Message-ID: <20090415235822.541dab69@terra.solaris> In-Reply-To: <20090415213516.758278d5@snowmobile> References: <20090412211447.536a297a@terra.solaris> <20090412203624.79ae97c3@snowmobile> <20090413110148.17d9cd5f@terra.solaris> <20090413170143.31087b9c@snowcone> <20090414104448.20153bfb@terra.solaris> <20090414140423.27055b57@snowcone> <20090414155543.16e78e66@terra.solaris> <20090414154657.37fb5ad8@snowcone> <20090415172801.382456e0@terra.solaris> <20090415213516.758278d5@snowmobile> X-Mailer: Claws Mail 3.7.1 (GTK+ 2.14.7; i686-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Package Manager Specification discussions X-BeenThere: gentoo-pms@gentoo.org X-BeenThere: gentoo-pms@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/3Fftl9l7HWr8smfG=A3qEb0"; protocol="application/pgp-signature"; micalg=PGP-SHA1 X-Archives-Salt: 639fb3bd-35f9-4c6d-a15e-b6213086efbd X-Archives-Hash: 5b47a205312e34f658ac04b0dd18555f --Sig_/3Fftl9l7HWr8smfG=A3qEb0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi, Ciaran McCreesh : > On Wed, 15 Apr 2009 17:28:01 +0200 > Christian Faulhammer wrote: > > > > 0001: Desk reference, updated and all issues you raised handled. > > >=20 > > > You're indenting with two spaces rather than four, and don't have > > > our precious vim modelines. Lack of consistency makes me cry! > >=20 > > Then go change the other files, and if Vim is too dumb to > > recognise a LaTeX file, I can't help it. >=20 > The modelines are there for indenting rules. And if everyone used > them, the other files wouldn't be in the mess they're in. Maybe. Emacs has set up indenting rules for LaTeX specifically, which is two spaces in all cases. And as far as I can see, vim needs the modeline for character set recognition and mode setting, while Emacs has some automagic which only makes setting the master file necessary...but enough from that. We are both biased. You haven't pushed the changes to github. > > And for inital review: > > 0008: Add Gentoo logo to PMS and desk reference. >=20 > What's the copyright / licence / author information for the logo? Gentoo Foundation holds the copyright and we can talk to the trustees about it. In the end, PMS is a Gentoo project. > There's something weird with convert -- if it doesn't support svg, it > exits successfully anyway. Not sure whether we can do anything about > that. Problem of the user...so a check for USE=3Dsvg on imagemagick is then needed in the ebuild for app-doc/pms. :)=20 > Can't get it to build, either: >=20 > ! LaTeX Error: File `gentoo-logo' not found. Because you haven't applied some of the patches. V-Li --=20 Christian Faulhammer, Gentoo Lisp project , #gentoo-lisp on FreeNode --Sig_/3Fftl9l7HWr8smfG=A3qEb0 Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.10 (GNU/Linux) iEYEARECAAYFAknmWIsACgkQNQqtfCuFnePrmwCff8imcJz2zvuONpVAFId56tO4 AY8AniKm9ndvxfWK0kZPcvFauCQVMQIR =EUOb -----END PGP SIGNATURE----- --Sig_/3Fftl9l7HWr8smfG=A3qEb0--