From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1LuBpM-0005rB-Bo for garchives@archives.gentoo.org; Wed, 15 Apr 2009 20:35:24 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 52642E0808; Wed, 15 Apr 2009 20:35:23 +0000 (UTC) Received: from mail-ew0-f163.google.com (mail-ew0-f163.google.com [209.85.219.163]) by pigeon.gentoo.org (Postfix) with ESMTP id EF338E0808 for ; Wed, 15 Apr 2009 20:35:22 +0000 (UTC) Received: by ewy7 with SMTP id 7so82361ewy.34 for ; Wed, 15 Apr 2009 13:35:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:in-reply-to:references:x-mailer:mime-version :content-type; bh=uXOE1Qxcg4/D8pVoZfm3vM2w15Ei1FNFycAGunrEA3E=; b=YSghsjiZOi9ONT8/Za+quD9LlUfksCUqIItkRiw8MizTN3LeGRU2dCpzTPOSESVbg0 iYSCNpZZe6dIFi8cUQmst1MUgvrERwji2Bs9Gk9Yuo72A4LQhhK26DXbgNHekWe9viwK GoKibgvFN3kfun49L5LL81z64KyAxS4un3RWg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type; b=jwsnd+7pVrkOGldslWq5XPndub9dY1PAwOlEMIVHnfopJ2Jf45Tz24/En/8lqFXLSS 1Yp9I5+fYMVnqBpr6XfNjr+GA3BnOi+EBUwryq5IGaG8F2Ww+8ZhkmK37HVShauTBrdk cSdZ2GesLindrheCu9Ao3XGoVJ/zS7LPu+XYw= Received: by 10.210.113.19 with SMTP id l19mr673124ebc.69.1239827722051; Wed, 15 Apr 2009 13:35:22 -0700 (PDT) Received: from snowmobile (92-235-187-79.cable.ubr18.sgyl.blueyonder.co.uk [92.235.187.79]) by mx.google.com with ESMTPS id 10sm320581eyd.13.2009.04.15.13.35.21 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 15 Apr 2009 13:35:21 -0700 (PDT) Date: Wed, 15 Apr 2009 21:35:16 +0100 From: Ciaran McCreesh To: Christian Faulhammer Cc: gentoo-pms@lists.gentoo.org Subject: Re: [gentoo-pms] Patches for your reviewing pleasure: Various improvements, including cheat sheet Message-ID: <20090415213516.758278d5@snowmobile> In-Reply-To: <20090415172801.382456e0@terra.solaris> References: <20090412211447.536a297a@terra.solaris> <20090412203624.79ae97c3@snowmobile> <20090413110148.17d9cd5f@terra.solaris> <20090413170143.31087b9c@snowcone> <20090414104448.20153bfb@terra.solaris> <20090414140423.27055b57@snowcone> <20090414155543.16e78e66@terra.solaris> <20090414154657.37fb5ad8@snowcone> <20090415172801.382456e0@terra.solaris> X-Mailer: Claws Mail 3.7.1 (GTK+ 2.16.0; i686-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Package Manager Specification discussions X-BeenThere: gentoo-pms@gentoo.org X-BeenThere: gentoo-pms@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/geK8GW33=LSpVkKnwtX+/qV"; protocol="application/pgp-signature" X-Archives-Salt: 3b913f12-b913-4f40-b1ba-67d3694406da X-Archives-Hash: 07ad3689ad4ceac54c3c57fbd017fd7c --Sig_/geK8GW33=LSpVkKnwtX+/qV Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 15 Apr 2009 17:28:01 +0200 Christian Faulhammer wrote: > > > 0001: Desk reference, updated and all issues you raised handled. > >=20 > > You're indenting with two spaces rather than four, and don't have > > our precious vim modelines. Lack of consistency makes me cry! >=20 > Then go change the other files, and if Vim is too dumb to recognise a > LaTeX file, I can't help it. The modelines are there for indenting rules. And if everyone used them, the other files wouldn't be in the mess they're in. Maybe. > 0001: Corrected desk reference. > + the previous EAPI. All label refer to the PMS document itself, > + built from the same checkout as this overview. s/label/labels/, and s/built/which can be built/ > + \item[IUSE defaults] An USE flag can be marked as mandatory (if A use flag, not an. > + function automatically. so small additions you need will not be That '.' should be a ','. I'd also say "so any small" rather than "so small". > 0002: Tell Emacs to use retarded indenting in all LaTeX files, so the > Vim weenies don't whine. Applied, thanks. > 0003: Fix intendation to 4 spaces where needed. Applied, minus the bits from 0001. > 0004: Comment class file Some of the lines in this one have trailing whitespace. Git moans about this, and it looks horrible. Can you get your editor to show you these so they don't slip through? Fixed up and applied, minus the bits from 0001. > 0005: Kick out appendix.sty and a little appendix tweak Applied, thanks. > 0006: Some minor Makefile tweaking This one needs 0001, so I've left it for now. > 0007: Make email addresses clickable Applied, thanks. > And for inital review: > 0008: Add Gentoo logo to PMS and desk reference. What's the copyright / licence / author information for the logo? You need to update .gitignore for the .png. There's something weird with convert -- if it doesn't support svg, it exits successfully anyway. Not sure whether we can do anything about that. Can't get it to build, either: ! LaTeX Error: File `gentoo-logo' not found. --=20 Ciaran McCreesh --Sig_/geK8GW33=LSpVkKnwtX+/qV Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (GNU/Linux) iEYEARECAAYFAknmRQYACgkQ96zL6DUtXhHPBQCg0YrU19GBnbqeHx+ZRGC6CtK/ OJ0AoN8zrqAOXfwXQaf+O+gxSBCuPOoL =Fqnp -----END PGP SIGNATURE----- --Sig_/geK8GW33=LSpVkKnwtX+/qV--