Re: [gentoo-pms] Patches for your reviewing pleasure: Various improvements, including cheat sheet

[Ciaran McCreesh <ciaran.mccreesh@googlemail.com>]

[-- Attachment #1: Type: text/plain, Size: 1802 bytes --]

On Sun, 12 Apr 2009 21:14:47 +0200
Christian Faulhammer <fauli@gentoo.org> wrote:
> on top of commit b1b3feb72b372d21d5d2443b7f7e9d0da2d84f29 in the
> eapi-3 branch:
> 
> 0001: Text body setting with bigger outer margin
> 0002: pms.cls, with report.cls and changing of label display.
> 0003: Fix a label. (No, I won't rebase it, as the label has been
> created by Ciaran)

Applied these three, thanks.

> 0004: The complete new EAPI 3 aware cheat sheet.

Some comments on this one:

Is the subdirectory necessary? Seems a bit weird to have it for one
thing.

Can we make each item have the PMS label name for full details at the
end of its paragraph? And add a new 'Other changes' item with the label
names of other changes not described?

The 'pkg_pretend' description should probably tell developers to
duplicate any checks done in pkg_setup.

I've stopped using 'uninstalled' for pkg_info in favour of
'non-installed'. Think it's less confusing.

'must be defined' is a bit dodgy for RDEPEND. 'Unset RDEPEND not set to
DEPEND' possibly.

The slot operator deps should include the : before the symbol.

Use dep defaults are in (+) and (-), not + or - on their own.

I'd mention the switch for docompress.

doins symlinks should say that it only works for -r. I probably need to
update the summaries for that too.

And some wording tinkering. Can cut the Abstract down to something like:

    An overview of the main EAPI changes in Gentoo, for ebuild authors.
    For full details, consult the Package Manager Specification; this
    is an incomplete summary only.

    Official EAPIs are consecutively numbered integers (0, 1, 2, ...).
    Except where otherwise noted, an EAPI is the same as the previous
    EAPI.

Cheers,
-- 
Ciaran McCreesh

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]