From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Lszms-0006ps-Te for garchives@archives.gentoo.org; Sun, 12 Apr 2009 13:31:55 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 213B2E03E7; Sun, 12 Apr 2009 13:31:54 +0000 (UTC) Received: from mo-p05-ob.rzone.de (mo-p05-ob.rzone.de [81.169.146.182]) by pigeon.gentoo.org (Postfix) with ESMTP id C520AE03E7 for ; Sun, 12 Apr 2009 13:31:53 +0000 (UTC) X-RZG-AUTH: :K2kKYU+nW/MMMlTokcN5Yot1/Bj/FTl+WviP6RIJci0HRMpbh/x+X6ShOQjVOj0+68LWLwoCNW8= X-RZG-CLASS-ID: mo05 Received: from terra.solaris (p54AE3D92.dip.t-dialin.net [84.174.61.146]) by post.strato.de (mrclete mo58) (RZmta 18.28) with ESMTP id p026c2l3CBZmkp ; Sun, 12 Apr 2009 15:31:50 +0200 (MEST) Date: Sun, 12 Apr 2009 15:31:26 +0200 From: Christian Faulhammer To: Ciaran McCreesh Cc: gentoo-pms@lists.gentoo.org Subject: Re: [gentoo-pms] EAPI 3 branch could use some reviewing Message-ID: <20090412153126.643a4c28@terra.solaris> In-Reply-To: <20090411211410.05b02d24@snowmobile> References: <20090411211410.05b02d24@snowmobile> X-Mailer: Claws Mail 3.7.1 (GTK+ 2.14.7; i686-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Package Manager Specification discussions X-BeenThere: gentoo-pms@gentoo.org X-BeenThere: gentoo-pms@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/f294CNRJl53/2727KGRYloH"; protocol="application/pgp-signature"; micalg=PGP-SHA1 X-Archives-Salt: 80d1b970-4aab-4c16-9bc7-b10d09f128c9 X-Archives-Hash: 3ee0cd5cdc1f2f91adb098511160a78c --Sig_/f294CNRJl53/2727KGRYloH Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi, Ciaran McCreesh : > I think I've removed all the TODO items and included everything that's > on the "possible" list for EAPI 3 now. I'd appreciate it if people > could give this a review before I send it to -dev@ and the Council. As far as I can see the commits are ok, although I wonder if "a use dependency" is correct. I learned at school that "an" is used in front of vowels, though I may have missed the exceptions because of sleeping in class. The explanations of the slot operators are a bit hard to read, maybe rephrasing (and splitting in more sentences) is the way to go here. Also I wonder if doexample and doinclude are good additions, but I have no strong opinion about it. Another thing: You should use \featurelabel not in a separate line but at the beginning of the fist line or at the end of the paragraph you want to mark, currently the margin marks aren't perfect. Something different: I pulled from the eapi-3 branch and made my patches apply on top of it: i) cheat sheet for EAPI 3 ii) pms.cls iii) better page layout They are not ready for shipping and I want to wait for EAPI 3 to settle. > 725d5ae..1c311de is formatting for the new margin labels thing. > This'll hopefully get modified before we go live with it. You want the page layout patches beforehand? V-Li --=20 Christian Faulhammer, Gentoo Lisp project , #gentoo-lisp on FreeNode --Sig_/f294CNRJl53/2727KGRYloH Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.10 (GNU/Linux) iEYEARECAAYFAknh7TcACgkQNQqtfCuFnePAzwCfXbjIV26dNBNjfwOa8aE8uy8K 5AQAnjkmd5nwnjGoX7cBaHkPXgnqDVxU =NeAw -----END PGP SIGNATURE----- --Sig_/f294CNRJl53/2727KGRYloH--