From: Ciaran McCreesh <ciaran.mccreesh@googlemail.com>
To: gentoo-pms@lists.gentoo.org
Subject: Re: [gentoo-pms] Some improvements
Date: Wed, 18 Feb 2009 19:15:51 +0000 [thread overview]
Message-ID: <20090218191551.07907916@snowcone> (raw)
In-Reply-To: <20090218175343.06c51147@terra.solaris>
[-- Attachment #1: Type: text/plain, Size: 826 bytes --]
On Wed, 18 Feb 2009 17:53:43 +0100
Christian Faulhammer <fauli@gentoo.org> wrote:
> Visual appearance of variables or options (minor changes)
> Patches 01--07
Could you squash all of these into fewer patches (probably one) please?
> punt table default-function-table, as the contents corresponds with
> default-phase-function-table
> Patches 08 and 21
Again, squash please.
> Page header, looks nicer in my eyes (and one bug fix introduced by my
> patch)
> Patches 09 and 12
And these.
> Fix all of the above
> Patches 13--20
And merge these into the relevant patches above.
It's easier if we keep our history nice and clean. Possibly not such a
big deal for non-code, but breaking then fixing things breaks bisect
and makes it harder to try out arbitrary revisions.
--
Ciaran McCreesh
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2009-02-18 19:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-18 16:53 [gentoo-pms] Some improvements Christian Faulhammer
2009-02-18 18:54 ` David Leverton
2009-02-19 9:27 ` Christian Faulhammer
2009-02-18 19:15 ` Ciaran McCreesh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090218191551.07907916@snowcone \
--to=ciaran.mccreesh@googlemail.com \
--cc=gentoo-pms@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox