* [gentoo-pms] [PATCH] Denote that src_test() can be disabled by user as well.
@ 2011-05-13 5:42 Michał Górny
2011-05-13 6:22 ` Ulrich Mueller
0 siblings, 1 reply; 6+ messages in thread
From: Michał Górny @ 2011-05-13 5:42 UTC (permalink / raw
To: gentoo-pms; +Cc: Michał Górny
Right now, the section on phase functions could suggest that src_test()
will be run always unless RESTRICT=test is specified. Try to clear that
up.
---
ebuild-functions.tex | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/ebuild-functions.tex b/ebuild-functions.tex
index a035fd4..230fda7 100644
--- a/ebuild-functions.tex
+++ b/ebuild-functions.tex
@@ -259,7 +259,8 @@ enabled, run \t{make check} if and only if such a target is available, or if not
if and only such a target is available. In both cases, if make returns non-zero the build must be
aborted.
-The \t{src\_test} function may be disabled by \t{RESTRICT}. See section~\ref{sec:restrict}.
+The \t{src\_test} function may be disabled by \t{RESTRICT}. See section~\ref{sec:restrict}. It may
+be disabled by~user too, using a~PM-specific mechanism.
\subsection{src\_install}
\label{sec:src-install-function}
@@ -434,7 +435,7 @@ The call order for installing a package is:
\item \t{src\_prepare} (only for EAPIs listed in table~\ref{tab:src-prepare-table})
\item \t{src\_configure} (only for EAPIs listed in table~\ref{tab:src-configure-table})
\item \t{src\_compile}
-\item \t{src\_test} (except if \t{RESTRICT=test})
+\item \t{src\_test} (except if \t{RESTRICT=test} or~disabled by~user)
\item \t{src\_install}
\item \t{pkg\_preinst}
\item \t{pkg\_postinst}
--
1.7.5.rc3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [gentoo-pms] [PATCH] Denote that src_test() can be disabled by user as well.
2011-05-13 5:42 [gentoo-pms] [PATCH] Denote that src_test() can be disabled by user as well Michał Górny
@ 2011-05-13 6:22 ` Ulrich Mueller
2011-05-13 12:50 ` Michał Górny
0 siblings, 1 reply; 6+ messages in thread
From: Ulrich Mueller @ 2011-05-13 6:22 UTC (permalink / raw
To: Michał Górny; +Cc: gentoo-pms
>>>>> On Fri, 13 May 2011, Michał Górny wrote:
> +be disabled by~user too, using a~PM-specific mechanism.
> +\item \t{src\_test} (except if \t{RESTRICT=test} or~disabled by~user)
Could you please use the ~ more sparingly? I don't see a reason why
line breaks at these points should be suppressed.
Ulrich
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [gentoo-pms] [PATCH] Denote that src_test() can be disabled by user as well.
2011-05-13 6:22 ` Ulrich Mueller
@ 2011-05-13 12:50 ` Michał Górny
2011-05-14 16:58 ` Ulrich Mueller
0 siblings, 1 reply; 6+ messages in thread
From: Michał Górny @ 2011-05-13 12:50 UTC (permalink / raw
To: Ulrich Mueller; +Cc: gentoo-pms
[-- Attachment #1: Type: text/plain, Size: 589 bytes --]
On Fri, 13 May 2011 08:22:23 +0200
Ulrich Mueller <ulm@gentoo.org> wrote:
> >>>>> On Fri, 13 May 2011, Michał Górny wrote:
>
> > +be disabled by~user too, using a~PM-specific mechanism.
>
> > +\item \t{src\_test} (except if \t{RESTRICT=test} or~disabled
> > by~user)
>
> Could you please use the ~ more sparingly? I don't see a reason why
> line breaks at these points should be suppressed.
The rules of typography state that prepositions should not appear
at the end of a line. But sure I can if you can tell me when to use it.
--
Best regards,
Michał Górny
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 316 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [gentoo-pms] [PATCH] Denote that src_test() can be disabled by user as well.
2011-05-13 12:50 ` Michał Górny
@ 2011-05-14 16:58 ` Ulrich Mueller
2011-05-14 19:47 ` Michał Górny
0 siblings, 1 reply; 6+ messages in thread
From: Ulrich Mueller @ 2011-05-14 16:58 UTC (permalink / raw
To: Michał Górny; +Cc: gentoo-pms
>>>>> On Fri, 13 May 2011, Michał Górny wrote:
>> > +be disabled by~user too, using a~PM-specific mechanism.
>>
>> > +\item \t{src\_test} (except if \t{RESTRICT=test} or~disabled
>> > by~user)
>>
>> Could you please use the ~ more sparingly? I don't see a reason why
>> line breaks at these points should be suppressed.
> The rules of typography state that prepositions should not appear at
> the end of a line.
I've consulted some typography books: The Chicago manual of style [1]
doesn't mention such a rule at all. Dowding [2] mentions it, but only
for ragged-edged columns, not for justified ones (also the book
doesn't follow such a rule for its own text).
However, the main point is that the document will be processed
automatically with very little human intervention. So we shouldn't
take away too many possible break points from TeX, otherwise we risk
uneven spacing or overfull hboxes.
> But sure I can if you can tell me when to use it.
So far, the only places where ~ is used is for cross references, i.e.
between the word "section", "table", etc., and the following number
(specified by \ref).
Ulrich
[1] The Chicago manual of style. 14th edition, Univ. of Chicago Press,
Chicago 1993. ISBN 0-226-10389-7.
[2] Geoffrey Dowding: Finer points in the spacing & arrangement of
type. Revised edition, Hartley & Marks, 1995. ISBN 0-88179-119-9.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [gentoo-pms] [PATCH] Denote that src_test() can be disabled by user as well.
2011-05-14 16:58 ` Ulrich Mueller
@ 2011-05-14 19:47 ` Michał Górny
2011-05-22 0:43 ` Ulrich Mueller
0 siblings, 1 reply; 6+ messages in thread
From: Michał Górny @ 2011-05-14 19:47 UTC (permalink / raw
To: gentoo-pms; +Cc: Michał Górny
Right now, the section on phase functions could suggest that src_test()
will be run always unless RESTRICT=test is specified. Try to clear that
up.
---
ebuild-functions.tex | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/ebuild-functions.tex b/ebuild-functions.tex
index a035fd4..51d9263 100644
--- a/ebuild-functions.tex
+++ b/ebuild-functions.tex
@@ -259,7 +259,8 @@ enabled, run \t{make check} if and only if such a target is available, or if not
if and only such a target is available. In both cases, if make returns non-zero the build must be
aborted.
-The \t{src\_test} function may be disabled by \t{RESTRICT}. See section~\ref{sec:restrict}.
+The \t{src\_test} function may be disabled by \t{RESTRICT}. See section~\ref{sec:restrict}. It may
+be disabled by user too, using a PM-specific mechanism.
\subsection{src\_install}
\label{sec:src-install-function}
@@ -434,7 +435,7 @@ The call order for installing a package is:
\item \t{src\_prepare} (only for EAPIs listed in table~\ref{tab:src-prepare-table})
\item \t{src\_configure} (only for EAPIs listed in table~\ref{tab:src-configure-table})
\item \t{src\_compile}
-\item \t{src\_test} (except if \t{RESTRICT=test})
+\item \t{src\_test} (except if \t{RESTRICT=test} or disabled by user)
\item \t{src\_install}
\item \t{pkg\_preinst}
\item \t{pkg\_postinst}
--
1.7.5.rc3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [gentoo-pms] [PATCH] Denote that src_test() can be disabled by user as well.
2011-05-14 19:47 ` Michał Górny
@ 2011-05-22 0:43 ` Ulrich Mueller
0 siblings, 0 replies; 6+ messages in thread
From: Ulrich Mueller @ 2011-05-22 0:43 UTC (permalink / raw
To: Michał Górny; +Cc: gentoo-pms
>>>>> On Sat, 14 May 2011, Michał Górny wrote:
> Right now, the section on phase functions could suggest that
> src_test() will be run always unless RESTRICT=test is specified.
> Try to clear that up.
Applied. Thanks.
Ulrich
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-05-22 0:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-13 5:42 [gentoo-pms] [PATCH] Denote that src_test() can be disabled by user as well Michał Górny
2011-05-13 6:22 ` Ulrich Mueller
2011-05-13 12:50 ` Michał Górny
2011-05-14 16:58 ` Ulrich Mueller
2011-05-14 19:47 ` Michał Górny
2011-05-22 0:43 ` Ulrich Mueller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox