From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1S0XOf-0005Wn-9a for garchives@archives.gentoo.org; Thu, 23 Feb 2012 12:03:41 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 3AEE7E0CC9 for ; Thu, 23 Feb 2012 12:03:40 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id B6110E07B7 for ; Thu, 23 Feb 2012 09:07:57 +0000 (UTC) Received: from [10.128.4.142] (unknown [79.170.210.172]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: hkbst) by smtp.gentoo.org (Postfix) with ESMTPSA id C70B61B4007 for ; Thu, 23 Feb 2012 09:07:56 +0000 (UTC) Message-ID: <4F46035F.5010201@gentoo.org> Date: Thu, 23 Feb 2012 10:14:07 +0100 From: Marijn User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120213 Thunderbird/10.0.1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Lisp mail X-BeenThere: gentoo-lisp@lists.gentoo.org Reply-To: gentoo-lisp@lists.gentoo.org MIME-Version: 1.0 To: gentoo-lisp@lists.gentoo.org Subject: Re: [gentoo-lisp] Finally, a fix for bug #335418, now what? References: <20120221210242.GD4377@gemini.falor> <4F44ECFA.5070303@gentoo.org> <20120222155632.GA4338@gemini.falor> In-Reply-To: <20120222155632.GA4338@gemini.falor> X-Enigmail-Version: 1.3.5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Archives-Salt: a598443a-4aeb-4b37-aec4-77b964a060a4 X-Archives-Hash: 73f67e90a2f2be9b21437480806dbc8d -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 22-02-12 16:56, Erik Falor wrote: > On Wed, Feb 22, 2012 at 02:26:18PM +0100, Marijn wrote: >> Hi Erik, >> >> you seem to have forgotten to actually attach anything. > > _____ _ _ _ | __ \( ) | | | | | | | |/ ___ | > |__ | | | | | | / _ \| '_ \| | | |__| | | (_) | | | |_| |_____/ > \___/|_| |_(_) > > My bad. > >> Anyway, it is fine if you commit stuff directly to the overlay, >> but it's not a bad idea to also post your patches to the list. > > Let's try this again... Hi Erik, I notice that the SRC_URI contains an explicit version. Ideally we shouldn't have to adjust it once 4.7.1 and 4.8.0 come out. Would ${PV} not accomplish that? I also notice that the ebuild still unsets some variables (A ARCH). I consider it a bug if this is necessary. Have you checked whether it is still necessary? If so what is the state of fixing portage so we don't need to do this unsetting? Otherwise looks good. Marijn -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk9GA18ACgkQp/VmCx0OL2wa4gCfQ7QJE95Lc/znjDPrIFhDPorA g7YAn0FbNBfh8FZY2McNrVr+XXUnnF1c =yWTa -----END PGP SIGNATURE-----