[gentoo-lisp] Finally, a fix for bug #335418, now what?

[gentoo-lisp] Finally, a fix for bug #335418, now what?

[Erik Falor]

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

Attached is an ebuild for =dev-scheme/chicken-4.7.0 which fixes
#335418.  Should I just check it in to the overlay, or does somebody
besides me need to take a look before I commit it?

-- 
Erik Falor
Registered Linux User #445632 http://linuxcounter.net

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: [gentoo-lisp] Finally, a fix for bug #335418, now what?

[Marijn]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 21-02-12 22:02, Erik Falor wrote:
> Attached is an ebuild for =dev-scheme/chicken-4.7.0 which fixes 
> #335418.  Should I just check it in to the overlay, or does
> somebody besides me need to take a look before I commit it?
> 

Hi Erik,

you seem to have forgotten to actually attach anything.
Anyway, it is fine if you commit stuff directly to the overlay, but
it's not a bad idea to also post your patches to the list.

Marijn
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEUEARECAAYFAk9E7PoACgkQp/VmCx0OL2y54QCYop38WIWhRND5h0lB/5S6VsEC
BQCghXLa1JuMHgQxKu+Ljm4ojz+y/38=
=dAIN
-----END PGP SIGNATURE-----

Re: [gentoo-lisp] Finally, a fix for bug #335418, now what?

[Erik Falor]

[-- Attachment #1.1: Type: text/plain, Size: 536 bytes --]

On Wed, Feb 22, 2012 at 02:26:18PM +0100, Marijn wrote:
> Hi Erik,
> 
> you seem to have forgotten to actually attach anything.

 _____  _       _     _
|  __ \( )     | |   | |
| |  | |/  ___ | |__ | |
| |  | |  / _ \| '_ \| |
| |__| | | (_) | | | |_|
|_____/   \___/|_| |_(_)

My bad.

> Anyway, it is fine if you commit stuff directly to the overlay, but
> it's not a bad idea to also post your patches to the list.

Let's try this again...

-- 
Erik Falor
Registered Linux User #445632 http://linuxcounter.net

[-- Attachment #1.2: chicken-4.7.0.ebuild --]
[-- Type: text/plain, Size: 2159 bytes --]

# Copyright 1999-2011 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
# $Header: $


EAPI="3"

inherit eutils multilib

DESCRIPTION="Chicken is a Scheme interpreter and native Scheme to C compiler"
HOMEPAGE="http://www.call-cc.org/"
SRC_URI="http://code.call-cc.org/releases/4.7.0/${P}.tar.gz"

LICENSE="BSD"
SLOT="0"
KEYWORDS="~alpha ~amd64 ~ppc ~ppc64 ~x86"
IUSE="emacs"

DEPEND="sys-apps/texinfo
		emacs? ( virtual/emacs )"
RDEPEND="emacs? ( virtual/emacs app-emacs/scheme-complete )"

## the major mode for Chicken source
SITEFILE=50hen-gentoo.el

src_prepare() {
	#Because chicken's Upstream have a custom to use variables that also
	#portage uses. Fixes #393561
	unset A ARCH
	sed "s,\$(PREFIX)/lib,\$(PREFIX)/$(get_libdir)," -i defaults.make || die "sed failed"
	sed "s,\$(DATADIR)/doc,\$(SHAREDIR)/doc/${P}," -i defaults.make || die "sed failed"
}

src_compile() {
	OPTIONS="PLATFORM=linux PREFIX=/usr"
	#Because chicken's Upstream have a custom to use variables that also
	#portage uses. Fixes #393561
	unset A ARCH

	#upstream does not yet support parallel builds, bug 265881
	#LINKER_OPTIONS doesn't seem to be incorporated into Makefile.linux -
	#might have to patch it...
	emake -j1 ${OPTIONS} C_COMPILER_OPTIMIZATION_OPTIONS="${CFLAGS}" \
		LINKER_OPTIONS="${LDFLAGS}" \
		HOSTSYSTEM="${CBUILD}" || die "emake failed"
}

# chicken's testsuite is not runnable before install
# upstream has been notified of the issue
RESTRICT=test

src_install() {
	#Because chicken's Upstream have a custom to use variables that also
	#portage uses. Fixes #393561
	unset A ARCH

	#upstream does not yet support parallel builds, bug 265881
	emake -j1 ${OPTIONS} DESTDIR="${D}" HOSTSYSTEM="${CBUILD}" \
		LINKER_OPTIONS="${LDFLAGS}" \
	install || die

	rm "${D}"/usr/share/doc/${P}/LICENSE || die
	dodoc NEWS || die

	if use emacs; then
		elisp-install ${PN} hen.{el,elc} || die
		elisp-site-file-install "${FILESDIR}"/${SITEFILE} || die
	fi
}

pkg_postinst()
{
	#Because we pass DESTDIR= to make back in src_install(), the build
	#won't automatically run chicken-install -update-db at that time.
	chicken-install -update-db
}

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: [gentoo-lisp] Finally, a fix for bug #335418, now what?

[Marijn]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 22-02-12 16:56, Erik Falor wrote:
> On Wed, Feb 22, 2012 at 02:26:18PM +0100, Marijn wrote:
>> Hi Erik,
>> 
>> you seem to have forgotten to actually attach anything.
> 
> _____  _       _     _ |  __ \( )     | |   | | | |  | |/  ___ |
> |__ | | | |  | |  / _ \| '_ \| | | |__| | | (_) | | | |_| |_____/
> \___/|_| |_(_)
> 
> My bad.
> 
>> Anyway, it is fine if you commit stuff directly to the overlay,
>> but it's not a bad idea to also post your patches to the list.
> 
> Let's try this again...

Hi Erik,

I notice that the SRC_URI contains an explicit version. Ideally we
shouldn't have to adjust it once 4.7.1 and 4.8.0 come out. Would ${PV}
not accomplish that?

I also notice that the ebuild still unsets some variables (A ARCH). I
consider it a bug if this is necessary. Have you checked whether it is
still necessary? If so what is the state of fixing portage so we don't
need to do this unsetting?

Otherwise looks good.

Marijn

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk9GA18ACgkQp/VmCx0OL2wa4gCfQ7QJE95Lc/znjDPrIFhDPorA
g7YAn0FbNBfh8FZY2McNrVr+XXUnnF1c
=yWTa
-----END PGP SIGNATURE-----

Re: [gentoo-lisp] Finally, a fix for bug #335418, now what?

[Erik Falor]

[-- Attachment #1.1: Type: text/plain, Size: 1097 bytes --]

On Thu, Feb 23, 2012 at 10:14:07AM +0100, Marijn wrote:
> Hi Erik,
> 
> I notice that the SRC_URI contains an explicit version. Ideally we
> shouldn't have to adjust it once 4.7.1 and 4.8.0 come out. Would ${PV}
> not accomplish that?

${PV} does accomplish that.  Thank you for pointing this out.

> I also notice that the ebuild still unsets some variables (A ARCH). I
> consider it a bug if this is necessary. Have you checked whether it is
> still necessary? If so what is the state of fixing portage so we don't
> need to do this unsetting?

Unfortunately, this step is still necessary as those variables are
still in conflict with the Makefiles.

I was not aware that there had been any discussion by the portage devs
about this issue.  The only bug I could find is #127560 - is that the
effort you are talking about?  Or are you suggesting that we file a
new bug?

> Otherwise looks good.
> 
> Marijn

If you feel good about just the ${PV} fix, I'll check this in to the
overlay tonight.

-- 
Erik Falor
Registered Linux User #445632 http://linuxcounter.net

[-- Attachment #1.2: chicken-4.7.0.ebuild --]
[-- Type: text/plain, Size: 2159 bytes --]

# Copyright 1999-2011 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
# $Header: $


EAPI="3"

inherit eutils multilib

DESCRIPTION="Chicken is a Scheme interpreter and native Scheme to C compiler"
HOMEPAGE="http://www.call-cc.org/"
SRC_URI="http://code.call-cc.org/releases/${PV}/${P}.tar.gz"

LICENSE="BSD"
SLOT="0"
KEYWORDS="~alpha ~amd64 ~ppc ~ppc64 ~x86"
IUSE="emacs"

DEPEND="sys-apps/texinfo
		emacs? ( virtual/emacs )"
RDEPEND="emacs? ( virtual/emacs app-emacs/scheme-complete )"

## the major mode for Chicken source
SITEFILE=50hen-gentoo.el

src_prepare() {
	#Because chicken's Upstream have a custom to use variables that also
	#portage uses. Fixes #393561
	unset A ARCH
	sed "s,\$(PREFIX)/lib,\$(PREFIX)/$(get_libdir)," -i defaults.make || die "sed failed"
	sed "s,\$(DATADIR)/doc,\$(SHAREDIR)/doc/${P}," -i defaults.make || die "sed failed"
}

src_compile() {
	OPTIONS="PLATFORM=linux PREFIX=/usr"
	#Because chicken's Upstream have a custom to use variables that also
	#portage uses. Fixes #393561
	unset A ARCH

	#upstream does not yet support parallel builds, bug 265881
	#LINKER_OPTIONS doesn't seem to be incorporated into Makefile.linux -
	#might have to patch it...
	emake -j1 ${OPTIONS} C_COMPILER_OPTIMIZATION_OPTIONS="${CFLAGS}" \
		LINKER_OPTIONS="${LDFLAGS}" \
		HOSTSYSTEM="${CBUILD}" || die "emake failed"
}

# chicken's testsuite is not runnable before install
# upstream has been notified of the issue
RESTRICT=test

src_install() {
	#Because chicken's Upstream have a custom to use variables that also
	#portage uses. Fixes #393561
	unset A ARCH

	#upstream does not yet support parallel builds, bug 265881
	emake -j1 ${OPTIONS} DESTDIR="${D}" HOSTSYSTEM="${CBUILD}" \
		LINKER_OPTIONS="${LDFLAGS}" \
	install || die

	rm "${D}"/usr/share/doc/${P}/LICENSE || die
	dodoc NEWS || die

	if use emacs; then
		elisp-install ${PN} hen.{el,elc} || die
		elisp-site-file-install "${FILESDIR}"/${SITEFILE} || die
	fi
}

pkg_postinst()
{
	#Because we pass DESTDIR= to make back in src_install(), the build
	#won't automatically run chicken-install -update-db at that time.
	chicken-install -update-db
}

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: [gentoo-lisp] Finally, a fix for bug #335418, now what?

[Marijn]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 23-02-12 18:50, Erik Falor wrote:
> On Thu, Feb 23, 2012 at 10:14:07AM +0100, Marijn wrote:
>> Hi Erik,
>> 
>> I notice that the SRC_URI contains an explicit version. Ideally
>> we shouldn't have to adjust it once 4.7.1 and 4.8.0 come out.
>> Would ${PV} not accomplish that?
> 
> ${PV} does accomplish that.  Thank you for pointing this out.
> 
>> I also notice that the ebuild still unsets some variables (A
>> ARCH). I consider it a bug if this is necessary. Have you checked
>> whether it is still necessary? If so what is the state of fixing
>> portage so we don't need to do this unsetting?
> 
> Unfortunately, this step is still necessary as those variables are 
> still in conflict with the Makefiles.
> 
> I was not aware that there had been any discussion by the portage
> devs about this issue.  The only bug I could find is #127560 - is
> that the effort you are talking about?  Or are you suggesting that
> we file a new bug?

I thought there was a specific bug about chicken's use of A and that
of portage conflicting, but I can't find it now. The Changelog isn't
very helpful either. I did find bug 208535 about a similar problem
with O which was resolved by fixing portage.
I think a good way to move forward is probably to just open a new bug
about this.

>> Otherwise looks good.
>> 
>> Marijn
> 
> If you feel good about just the ${PV} fix, I'll check this in to
> the overlay tonight.

You should feel free to commit stuff even if it is has some issues;
that's what we have the overlay for. The main tree is a different
story, but for the overlay the bar is intentionally really low. That
way people can cooperate and improve on each-other's work easily.

Marijn

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk9HilAACgkQp/VmCx0OL2wzTgCfcUHrsRR+Y4cG324JabQW/mgg
qIUAn2+KBVFE2nuUcnwdtAWP7d85ozzd
=fhRo
-----END PGP SIGNATURE-----

Re: [gentoo-lisp] Finally, a fix for bug #335418, now what?

[Erik Falor]

[-- Attachment #1: Type: text/plain, Size: 833 bytes --]

On Fri, Feb 24, 2012 at 02:02:08PM +0100, Marijn wrote:
> > If you feel good about just the ${PV} fix, I'll check this in to
> > the overlay tonight.

Speaking of bugs, it turns out that I somehow submitted my Cygwin
(dayjob) box's SSH pubkey to bug #395653.  Now I cannot push to the
overlay from my Gentoo box at home!

This is the correct pubkey:

ssh-rsa AAAAB3NzaC1yc2EAAAABIwAAAQEA2qaklk5yGWpnrTuFjQOsTKgwIw1MZ+9l1OWdCAnDM+69MGenD44g3tytjkWD1SCgZV503BliBCYDvgGHRwDhMXuhZwyCv2XHaoSXP/uH4meOSWm4DTpAYHsv6DP8Un8g8lYI+qMTWWKztVB9yHF2JEFyxZPez45v+IV7HiYeC0O78PNyUg19mC3Mt0n2RjqHmRZuz7oAZ0SSECsKTvCNi31ritkQyHpkdsUILbfRtdRt1Mjl/2bm2T+0FKWlJDRedIcXJu1zgOxDJ0CaJ6OOicOsodnigsc6lhOrynIwTd+JmkGKjtiCWU2CGCFi0PZ+1rqRMuILMPdsNJUPRoU8qw== fadein@gemini


-- 
Erik Falor
Registered Linux User #445632 http://linuxcounter.net

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: [gentoo-lisp] Finally, a fix for bug #335418, now what?

[Marijn]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 26-02-12 05:21, Erik Falor wrote:
> On Fri, Feb 24, 2012 at 02:02:08PM +0100, Marijn wrote:
>>> If you feel good about just the ${PV} fix, I'll check this in 
>>> to the overlay tonight.
> 
> Speaking of bugs, it turns out that I somehow submitted my Cygwin 
> (dayjob) box's SSH pubkey to bug #395653.  Now I cannot push to the
> overlay from my Gentoo box at home!
> 
> This is the correct pubkey:
> 
> ssh-rsa AAAA

please take it up with the overlay admins,

Marijn
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk9LXoUACgkQp/VmCx0OL2yhUACfWU5uaWSC1qoyl5oUjZR12YOp
wFsAoLyM8nxusUhxeobwGWB4N7oc7+Y+
=Ym8+
-----END PGP SIGNATURE-----