From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org)
	by finch.gentoo.org with esmtp (Exim 4.60)
	(envelope-from <gentoo-lisp+bounces-198-garchives=archives.gentoo.org@lists.gentoo.org>)
	id 1S0d12-00046h-DW
	for garchives@archives.gentoo.org; Thu, 23 Feb 2012 18:03:40 +0000
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 09D67E0D70
	for <garchives@archives.gentoo.org>; Thu, 23 Feb 2012 18:03:39 +0000 (UTC)
Received: from mail-gx0-f181.google.com (mail-gx0-f181.google.com [209.85.161.181])
	by pigeon.gentoo.org (Postfix) with ESMTP id 61873E0D47
	for <gentoo-lisp@lists.gentoo.org>; Thu, 23 Feb 2012 17:51:04 +0000 (UTC)
Received: by ggnv5 with SMTP id v5so891097ggn.40
        for <gentoo-lisp@lists.gentoo.org>; Thu, 23 Feb 2012 09:51:03 -0800 (PST)
Received-SPF: pass (google.com: domain of ewfalor@gmail.com designates 10.236.72.167 as permitted sender) client-ip=10.236.72.167;
Authentication-Results: mr.google.com; spf=pass (google.com: domain of ewfalor@gmail.com designates 10.236.72.167 as permitted sender) smtp.mail=ewfalor@gmail.com; dkim=pass header.i=ewfalor@gmail.com
Received: from mr.google.com ([10.236.72.167])
        by 10.236.72.167 with SMTP id t27mr4651406yhd.79.1330019463942 (num_hops = 1);
        Thu, 23 Feb 2012 09:51:03 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=date:from:to:subject:message-id:mail-followup-to:references
         :mime-version:content-type:content-disposition:in-reply-to
         :user-agent;
        bh=Y5a32IPYDHklTmpn+FMXDAMbZTA2HXj6fb3ldauXCuc=;
        b=qkzhyb51s/sBRQyX4E2dvskwGSWd5lXiYgyvbYwx5nW+eT2qjU/quEpLG8AznBadql
         LEpLqTF9uoWaFT44gj0Qrkp6weuieVlQsi8Kv3veVea5UfKKFxvurDtD0pbxb5ObH5aB
         Hf8FgG7D/PwbULI3IOukkT1LrbAz9B0DNGCW8=
Received: by 10.236.72.167 with SMTP id t27mr3756157yhd.79.1330019463716;
        Thu, 23 Feb 2012 09:51:03 -0800 (PST)
Received: from gemini.falor (c-67-161-246-186.hsd1.ut.comcast.net. [67.161.246.186])
        by mx.google.com with ESMTPS id w44sm5258726yhk.17.2012.02.23.09.51.01
        (version=SSLv3 cipher=OTHER);
        Thu, 23 Feb 2012 09:51:02 -0800 (PST)
Date: Thu, 23 Feb 2012 10:50:57 -0700
From: Erik Falor <ewfalor@gmail.com>
To: gentoo-lisp@lists.gentoo.org
Subject: Re: [gentoo-lisp] Finally, a fix for bug #335418, now what?
Message-ID: <20120223175057.GA3896@gemini.falor>
Mail-Followup-To: gentoo-lisp@lists.gentoo.org
References: <20120221210242.GD4377@gemini.falor>
 <4F44ECFA.5070303@gentoo.org>
 <20120222155632.GA4338@gemini.falor>
 <4F46035F.5010201@gentoo.org>
Precedence: bulk
List-Post: <mailto:gentoo-lisp@lists.gentoo.org>
List-Help: <mailto:gentoo-lisp+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-lisp+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-lisp+subscribe@lists.gentoo.org>
List-Id: Gentoo Lisp mail <gentoo-lisp.gentoo.org>
X-BeenThere: gentoo-lisp@lists.gentoo.org
Reply-To: gentoo-lisp@lists.gentoo.org
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="JP+T4n/bALQSJXh8"
Content-Disposition: inline
In-Reply-To: <4F46035F.5010201@gentoo.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Archives-Salt: 6d7f0e1b-acf5-4578-8d49-e808bbd0c165
X-Archives-Hash: 6cdfbc2ced788fa217c9fbb668736844


--JP+T4n/bALQSJXh8
Content-Type: multipart/mixed; boundary="0OAP2g/MAC+5xKAE"
Content-Disposition: inline


--0OAP2g/MAC+5xKAE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 23, 2012 at 10:14:07AM +0100, Marijn wrote:
> Hi Erik,
>=20
> I notice that the SRC_URI contains an explicit version. Ideally we
> shouldn't have to adjust it once 4.7.1 and 4.8.0 come out. Would ${PV}
> not accomplish that?

${PV} does accomplish that.  Thank you for pointing this out.

> I also notice that the ebuild still unsets some variables (A ARCH). I
> consider it a bug if this is necessary. Have you checked whether it is
> still necessary? If so what is the state of fixing portage so we don't
> need to do this unsetting?

Unfortunately, this step is still necessary as those variables are
still in conflict with the Makefiles.

I was not aware that there had been any discussion by the portage devs
about this issue.  The only bug I could find is #127560 - is that the
effort you are talking about?  Or are you suggesting that we file a
new bug?

> Otherwise looks good.
>=20
> Marijn

If you feel good about just the ${PV} fix, I'll check this in to the
overlay tonight.

--=20
Erik Falor
Registered Linux User #445632 http://linuxcounter.net

--0OAP2g/MAC+5xKAE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="chicken-4.7.0.ebuild"

# Copyright 1999-2011 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
# $Header: $


EAPI="3"

inherit eutils multilib

DESCRIPTION="Chicken is a Scheme interpreter and native Scheme to C compiler"
HOMEPAGE="http://www.call-cc.org/"
SRC_URI="http://code.call-cc.org/releases/${PV}/${P}.tar.gz"

LICENSE="BSD"
SLOT="0"
KEYWORDS="~alpha ~amd64 ~ppc ~ppc64 ~x86"
IUSE="emacs"

DEPEND="sys-apps/texinfo
		emacs? ( virtual/emacs )"
RDEPEND="emacs? ( virtual/emacs app-emacs/scheme-complete )"

## the major mode for Chicken source
SITEFILE=50hen-gentoo.el

src_prepare() {
	#Because chicken's Upstream have a custom to use variables that also
	#portage uses. Fixes #393561
	unset A ARCH
	sed "s,\$(PREFIX)/lib,\$(PREFIX)/$(get_libdir)," -i defaults.make || die "sed failed"
	sed "s,\$(DATADIR)/doc,\$(SHAREDIR)/doc/${P}," -i defaults.make || die "sed failed"
}

src_compile() {
	OPTIONS="PLATFORM=linux PREFIX=/usr"
	#Because chicken's Upstream have a custom to use variables that also
	#portage uses. Fixes #393561
	unset A ARCH

	#upstream does not yet support parallel builds, bug 265881
	#LINKER_OPTIONS doesn't seem to be incorporated into Makefile.linux -
	#might have to patch it...
	emake -j1 ${OPTIONS} C_COMPILER_OPTIMIZATION_OPTIONS="${CFLAGS}" \
		LINKER_OPTIONS="${LDFLAGS}" \
		HOSTSYSTEM="${CBUILD}" || die "emake failed"
}

# chicken's testsuite is not runnable before install
# upstream has been notified of the issue
RESTRICT=test

src_install() {
	#Because chicken's Upstream have a custom to use variables that also
	#portage uses. Fixes #393561
	unset A ARCH

	#upstream does not yet support parallel builds, bug 265881
	emake -j1 ${OPTIONS} DESTDIR="${D}" HOSTSYSTEM="${CBUILD}" \
		LINKER_OPTIONS="${LDFLAGS}" \
	install || die

	rm "${D}"/usr/share/doc/${P}/LICENSE || die
	dodoc NEWS || die

	if use emacs; then
		elisp-install ${PN} hen.{el,elc} || die
		elisp-site-file-install "${FILESDIR}"/${SITEFILE} || die
	fi
}

pkg_postinst()
{
	#Because we pass DESTDIR= to make back in src_install(), the build
	#won't automatically run chicken-install -update-db at that time.
	chicken-install -update-db
}

--0OAP2g/MAC+5xKAE--

--JP+T4n/bALQSJXh8
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)

iEYEARECAAYFAk9GfIEACgkQpMTu6iYtwsfwNACePXDfQF8DCoRrro+hJQ8ZyBSf
EwEAn0ABy1vBfmBvDNR6KPYXzvnsD6fz
=A/MV
-----END PGP SIGNATURE-----

--JP+T4n/bALQSJXh8--