From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 3918F1381F3 for ; Fri, 16 Aug 2013 00:03:24 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B6DDEE0D9E; Fri, 16 Aug 2013 00:03:23 +0000 (UTC) Received: from toothrot.meleeweb.net (fr1.as29.net [88.190.23.70]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 2800CE0D9D for ; Fri, 16 Aug 2013 00:03:23 +0000 (UTC) Received: from cook.melee ([10.34.83.3] helo=cook.scabb) by toothrot.meleeweb.net with esmtps (TLSv1:DHE-RSA-AES256-SHA:256) id 1VA7Vh-0007Hi-Lm; Fri, 16 Aug 2013 02:03:21 +0200 Received: from lemonhead.scabb ([2a01:e35:2422:da50:941:20:1:136]) by cook.scabb with esmtp id 1VA7Vf-0004t7-SW; Fri, 16 Aug 2013 02:03:19 +0200 Date: Fri, 16 Aug 2013 02:03:19 +0200 From: Bertrand Jacquin To: gentoo-kernel@lists.gentoo.org Cc: Tom Wijsman Subject: Re: [gentoo-kernel] [ANNOUNCE] genpatches-3.10-12 release Message-ID: <20130816000319.GH2953@lemonhead.scabb> References: <20130815215512.34DC833EB48@smtp.gentoo.org> <4f6d9a135bf17a97664c9f085567ecd5@mail.meleeweb.net> <20130816014912.39d9af60@TOMWIJ-GENTOO> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-kernel@lists.gentoo.org Reply-to: gentoo-kernel@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20130816014912.39d9af60@TOMWIJ-GENTOO> Jabber-ID: beber@meleeweb.net X-GPG-Key: 0x39BB8CF4 X-GPG-DirectLink: https://www.cacert.org/gpg.php?id=3&cert=14964 X-GPG-Fingerprint: 2CBD 6A23 D980 3E32 66D1 573D 89B8 C953 39BB 8CF4 X-Pants: Off User-Agent: Mutt/1.5.21 (2010-09-15) X-Archives-Salt: 11fd5644-1484-4647-83ff-ed2acc846fdd X-Archives-Hash: 27c8ac2afbbfb4e6c4a544daa79a1166 D'ar gwener 16 a viz Eost 2013 e 01 eur 49, « Tom Wijsman » he deus skrivet : > On Fri, 16 Aug 2013 01:27:23 +0200 > Bertrand Jacquin wrote: > > > 3.10-12/2300_USB-mount-extd-inq-cmd-fix.patch does not apply anymore > > as was included upstream at commit > > 0ac10bd036f0f3b8ce7ac2390446eab9531c72eb (v3.10.6-1-g0ac10bd) > > Thank you very much for letting us know! > > There is one subtle difference here; specifically, it does apply. > > Unpacking source... > Unpacking linux-3.10.tar.xz > to /var/tmp/portage/sys-kernel/gentoo-sources-3.10.7/work > Unpacking genpatches-3.10-12.base.tar.xz > to /var/tmp/portage/sys-kernel/gentoo-sources-3.10.7/work/patches > Unpacking genpatches-3.10-12.extras.tar.xz > to /var/tmp/portage/sys-kernel/gentoo-sources-3.10.7/work/patches > * Applying 1000_linux-3.10.1.patch > (-p1) ... [ ok ] > * Applying 1001_linux-3.10.2.patch > (-p1) ... [ ok ] > * Applying 1002_linux-3.10.3.patch > (-p1) ... [ ok ] > * Applying 1003_linux-3.10.4.patch > (-p1) ... [ ok ] > * Applying 1004_linux-3.10.5.patch > (-p1) ... [ ok ] > * Applying 1005_linux-3.10.6.patch > (-p1) ... [ ok ] > * Applying 1006_linux-3.10.7.patch > (-p1) ... [ ok ] > * Applying 1500_XATTR_USER_PREFIX.patch > (-p1) ... [ ok ] > * Applying 1700_enable-thinkpad-micled.patch > (-p1) ... [ ok ] > * Applying > 1801_block-cgroups-kconfig-build-bits-for-BFQ-v6r2-3.10.patch > (-p1) ... [ ok ] > * Applying 1802_block-introduce-the-BFQ-v6r2-I-O-sched-for-3.10.patch1 > (-p1) ... [ ok ] > * Applying > 1803_block-bfq-add-Early-Queue-Merge-EQM-to-BFQ-v6r2-for-3.10.0.patch1 > (-p1) ... [ ok ] > * Applying 2300_USB-mount-extd-inq-cmd-fix.patch > (-p1) ... [ ok ] > * Applying 2400_kcopy-patch-for-infiniband-driver.patch > (-p1) ... [ ok ] > * Applying 2700_ThinkPad-30-brightness-control-fix.patch > (-p1) ... [ ok ] > * Applying 2900_dev-root-proc-mount-fix.patch > (-p1) ... [ ok ] > * Applying 4200_fbcondecor-0.9.6.patch > (-p1) ... [ ok ] > * Applying 4500_nouveau-video-output-control-Kconfig.patch > (-p1) ... [ ok ] > * Applying 4567_distro-Gentoo-Kconfig.patch > (-p1) ... [ ok ] > Source unpacked > in /var/tmp/portage/sys-kernel/gentoo-sources-3.10.7/work > > Inspecting it I agree it does apply a bit weirdly; although, it does > make the intent of the code the same and should thus not be a problem. > > if (sdev->skip_vpd_pages) > goto fail; > > if (sdev->skip_vpd_pages) > goto fail; > > Using =sys-devel/patch-2.7.1-r2 here. Why does it not apply for you? First of all, I'm not using gentoo-sources but a personal ebuild that actually take patch, apply them, then build the kernel, see #472906 or http://git.meleeweb.net/cgit.cgi/distros/gentoo/portage.git/tree/sys-kernel/longterm-sources and http://git.meleeweb.net/cgit.cgi/distros/gentoo/portage.git/tree/sys-kernel/stable-sources This ebuild use epatch_user, so all my patchs are taken from http://git.meleeweb.net/cgit.cgi/linux-patchset.git/tree/ $ git clone git://git.meleeweb.net/var/git/linux-patchset.git /etc/portage/patches/sys-kernel Actually I have a simple script that 'prepare' the patch tree. I just apply ja patch, 'git am' all my own/companie patch, then apply gentoo one from genpatch svn. That script first try to 'git am' the patch if that one has the good format. If it does not, it simply do a 'patch -sNp1 < "${patch}"' So it should not fail as '-N' (Ignore patches that seem to be reversed or already applied). Argg ... :) I use sys-devel/patch-2.7.1-r2 as you. I need to inspect what do epatch a bit better to be able to reproduce. But speaking in pure QA, it's better is this case :) > Anyhow, just for safety reasons I'll push out a new genpatches; as it > intends to fix a build issue, it doesn't require a revision bump. :) Thanks ! -- Beber