public inbox for gentoo-kernel@lists.gentoo.org
 help / color / mirror / Atom feed
From: Tom Wijsman <TomWij@gentoo.org>
To: gentoo-kernel@lists.gentoo.org
Cc: jlec@gentoo.org
Subject: Re: [gentoo-kernel] Notice of addition of "4567_distro-Gentoo-Kconfig.patch" ("Add Gentoo Linux support config settings and defaults.") to genpatches.
Date: Thu, 15 Aug 2013 20:54:56 +0200	[thread overview]
Message-ID: <20130815205456.6620e6ea@TOMWIJ-GENTOO> (raw)
In-Reply-To: <520D1733.9080607@gentoo.org>

[-- Attachment #1: Type: text/plain, Size: 1390 bytes --]

On Thu, 15 Aug 2013 20:00:19 +0200
Justin <jlec@gentoo.org> wrote:

> On 15/08/13 19:28, Tom Wijsman wrote:
> > Hello
> > 
> > 
> > 
> > If you maintain kernels based on genpatches for a non Gentoo Linux
> > audience and do not want a Gentoo Linux menu or Gentoo Linux
> > defaults present on those particular kernels; then I want to make
> > you aware that you need to ensure that you drop
> > 4567_distro-Gentoo-Kconfig.patch from the patch set after
> > extraction.
> > 
> 
> How about adding this patch to an extra tarball so that we can simply
> switch it of be not setting it in K_WANT_GENPATCHES?

This complicates the eclass, genpatches scripts and all in tree ebuilds
for a single patch in a single tarball; why not just exclude it if you
explicitly don't want it? It's not much more than your proposal; so,
excluding the patch seems like a much more simpler approach.

Alternatively, people can add a patch that patches away ./Kconfig:11.

This is also meant to be opt-out and not opt-in; as in the end, this
change causes documentation changes and thus must be present in any
kernel on Gentoo Linux, otherwise we are introducing inconsistency.

-- 
With kind regards,

Tom Wijsman (TomWij)
Gentoo Developer

E-mail address  : TomWij@gentoo.org
GPG Public Key  : 6D34E57D
GPG Fingerprint : C165 AF18 AB4C 400B C3D2  ABF0 95B2 1FCD 6D34 E57D

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

      reply	other threads:[~2013-08-15 18:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-15 17:28 [gentoo-kernel] Notice of addition of "4567_distro-Gentoo-Kconfig.patch" ("Add Gentoo Linux support config settings and defaults.") to genpatches Tom Wijsman
2013-08-15 18:00 ` Justin
2013-08-15 18:54   ` Tom Wijsman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130815205456.6620e6ea@TOMWIJ-GENTOO \
    --to=tomwij@gentoo.org \
    --cc=gentoo-kernel@lists.gentoo.org \
    --cc=jlec@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox