On 1/15/08, William L. Thomson Jr. <wltjr@gentoo.org> wrote:

On Tue, 2008-01-15 at 17:38 +0100, Jean-Noël Rivasseau wrote:
> Hello,
>
> I unfortunately discovered today that Eclipse-3.3 won't build against
> jsch-0.1.36, although I assumed it would. It builds against 0.1.34.
>
> Shall I then slot 0.1.34 and 0.1.36? Seems stupid to slot between such
> minor version revisions, but since upstream breaks API...
> Else I can restrict Eclipse dependency on jsch to 0.1.34 but this will
> prevent people to install 0.1.36 - not good.
>
> Jean-Noël
>
> PS: the reason it does not compile anymore is that on 0.1.36 one
> function can throw an exception whereas it did not before, and Eclipse
> code does not expect an exception. I could patch Eclipse but I don't
> really want to go that way, because:
> 1) I really wouldn't know how to patch exactly and prefer to leave
> these stuff to upstream;
> 2) It may very well be that a lot of the API has changed.

Can you check to see how many places in Eclipse would need to be
modified. See how many other apps that would benefit from having jsch
slotted. Also might check in their vc system to see if they have
modified things already for a newer jsch.

We surely have no problem slotting stuff on the Java front. Lots of
stuff is already and likely more stuff with. Very likely jsch is a
candidate. If more than just Eclipse could benefit from it.

If it's only Eclipse and doesn't require major code modifications. Might
seriously consider a patch. Prevents us from having to slot. Plus you
can provide patch to upstream for future releases. Likely get you some
bonus points with upstream. The faster and better you can establish a
relationship with upstream. The better your life will be while
maintaining Eclipse :)

FYI, I am about to patch Tomcat per something upstream wouldn't comment
on. Redirecting stdout/stdin via System.setErr/setOut. Verses using
shell redirection to populate catalina.out. Now that's going pretty much
against upstream. A modification they may or may not ever make. In your
case, at some point the Eclipse code base will be updated for a newer
jsch. So you doing it and contributing that, will help them.

--
William L. Thomson Jr.
Gentoo/amd64/Java