From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by nuthatch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1GQGl0-0006xX-BQ for garchives@archives.gentoo.org; Thu, 21 Sep 2006 05:05:54 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.13.8/8.13.6) with SMTP id k8L55AnI024626; Thu, 21 Sep 2006 05:05:10 GMT Received: from wx-out-0506.google.com (wx-out-0506.google.com [66.249.82.231]) by robin.gentoo.org (8.13.8/8.13.6) with ESMTP id k8L559xB026457 for ; Thu, 21 Sep 2006 05:05:09 GMT Received: by wx-out-0506.google.com with SMTP id r21so625214wxc for ; Wed, 20 Sep 2006 22:05:09 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=oSt47plM6C6wVgTJ4HIS/HNuR3Bah6nqDm6kJkpWdAKG5z+qENy+wSzZfKnmRLZN9tkKKTOCrZ2HyflzHdPK5JKIXJZXmL7wOUQb7vI1WkKBDSe0Tef4sB6gKnjrmJMT4p6tRl6Epl1ZgOJpv26gJaLFcBj4ZFVcGUg35drvjf0= Received: by 10.70.109.4 with SMTP id h4mr26202957wxc; Wed, 20 Sep 2006 22:05:09 -0700 (PDT) Received: by 10.70.19.18 with HTTP; Wed, 20 Sep 2006 22:05:08 -0700 (PDT) Message-ID: <9e0cf0bf0609202205l3b79649y93e87f84ab3cdc79@mail.gmail.com> Date: Thu, 21 Sep 2006 08:05:08 +0300 From: "Alon Bar-Lev" To: "Vlastimil Babka" Subject: Re: [gentoo-java] generation-2 java eclass Cc: gentoo-java@lists.gentoo.org In-Reply-To: <4511C3B6.5020802@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-java@gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200609152007.32247.alon.barlev@gmail.com> <450C8B52.8050707@gentoo.org> <200609201307.51119.alon.barlev@gmail.com> <4511A52B.2010700@gentoo.org> <4511C3B6.5020802@gentoo.org> X-Archives-Salt: 666bc471-6905-4dfb-8118-49a486fcdb48 X-Archives-Hash: 705d5487193d7c8f74f591445a5b1910 On 9/21/06, Vlastimil Babka wrote: > Vlastimil Babka wrote: > > >> Must be a typo. As a result, java env is probably not set properly > > >> inside ebuild's pkg_setup() (for ebuilds that define it). But since > > >> there are correct hooks for other phases (especially src_compile) > > >> it didn't cause any harm so far. > > > > > > Should I open a bug for it, or you can fix it? > > > > I can fix it but I just found out that portage seems to ignore > > pre_pkg_setup() hook anyway. Will need to talk to portage people if > > that's feature or bug. > > Sorry, was wrong on this one. Hook works correctly. I've now fixed the > typo in eclass. Thanks. Looking at bug#146647, why did you remove the java from the IUSE? I don't think it is a clean to require programmer to define the JAVA_PKG_OPT_USE before the inherit... Or you need to add a BIG FAT WARNING at the eclass documentation/description. And shouldn't the package append the USE fag (IUSE="${IUSE} ${JAVA_PKG_OPT_USE}") instead of replacing it? And in order to solve the conflict that may introduce when several eclasses overwrite the pre* functions, shouldn't you EXPORT_FUNCTIONS them? Best Regards, Alon Bar-Lev. -- gentoo-java@gentoo.org mailing list