Re: [gentoo-java] generation-2 java eclass

["Alon Bar-Lev" <alon.barlev@gmail.com>]

On 9/21/06, Vlastimil Babka <caster@gentoo.org> wrote:
> Vlastimil Babka wrote:
> >  >> Must be a typo. As a result, java env is probably not set properly
> >  >> inside ebuild's pkg_setup() (for ebuilds that define it). But since
> >  >> there are correct hooks for other phases (especially src_compile)
> >  >> it didn't cause any harm so far.
> >  >
> >  > Should I open a bug for it, or you can fix it?
> >
> > I can fix it but I just found out that portage seems to ignore
> > pre_pkg_setup() hook anyway. Will need to talk to portage people if
> > that's feature or bug.
>
> Sorry, was wrong on this one. Hook works correctly. I've now fixed the
> typo in eclass.

Thanks.

Looking at bug#146647, why did you remove the java from the IUSE? I
don't think it is a clean to require programmer to define the
JAVA_PKG_OPT_USE before the inherit... Or you need to add a BIG FAT
WARNING at the eclass documentation/description.

And shouldn't the package append the USE fag (IUSE="${IUSE}
${JAVA_PKG_OPT_USE}") instead of replacing it?

And in order to solve the conflict that may introduce when several
eclasses overwrite the pre* functions, shouldn't you EXPORT_FUNCTIONS
them?

Best Regards,
Alon Bar-Lev.
-- 
gentoo-java@gentoo.org mailing list