public inbox for gentoo-java@lists.gentoo.org
 help / color / mirror / Atom feed
From: Vlastimil Babka <caster@gentoo.org>
To: "\"Miroslav Šulc (fordfrog)\"" <fordfrog@gentoo.org>
Cc: gentoo-java <gentoo-java@lists.gentoo.org>
Subject: [gentoo-java] Re: java-dep-check on ant tasks
Date: Mon, 31 Jan 2011 02:14:23 +0100	[thread overview]
Message-ID: <4D460CEF.8010508@gentoo.org> (raw)
In-Reply-To: <4D36FD33.5010508@gentoo.org>

On 01/19/2011 04:03 PM, "Miroslav Šulc (fordfrog)" wrote:
> hi,
>
> i was looking at the issues when some classes cannot be found via
> DEPENDS, like http://bugs.gentoo.org/show_bug.cgi?id=298689. the problem
> is that DEPENDS for ant tasks does not contain dependency on ant-core.
> this patch below could fix it (at least it fixed the issue for me and
> testing some junit ant tasks while emerging packages with
> FEATURES="test" worked too):

This could work for ant-tasks themselves, but not for everything else 
that has ant-core dependency, such as when a package provides some ant 
task. In that case, the depending classes are needed only when invoked 
from within ant, in which case they are already on classpath. 
Registering as dependency would make ant put on classpath in all cases 
the package is used.
The bottom line is, there should be a way to exclude stuff (such as ant 
classes) in java-dep-check.

BTW, the mailing list is better than the java alias for this. Seems to 
get much less spam as I see it :)

Vlastimil

> $ cvs diff ant-tasks.eclass
> Index: ant-tasks.eclass
> ===================================================================
> RCS file: /var/cvsroot/gentoo-x86/eclass/ant-tasks.eclass,v
> retrieving revision 1.8
> diff -r1.8 ant-tasks.eclass
> 174a176
>>      java-pkg_register-dependency ant-core ant.jar
>
> any objections against committing this?
>
> miroslav




       reply	other threads:[~2011-01-31  1:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4D36FD33.5010508@gentoo.org>
2011-01-31  1:14 ` Vlastimil Babka [this message]
2011-01-31  1:43   ` [gentoo-java] Re: java-dep-check on ant tasks "Miroslav Šulc (fordfrog)"
2011-01-31  4:21     ` Alistair Bush

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D460CEF.8010508@gentoo.org \
    --to=caster@gentoo.org \
    --cc=fordfrog@gentoo.org \
    --cc=gentoo-java@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox