From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Lz80c-0001iP-Bk for garchives@archives.gentoo.org; Wed, 29 Apr 2009 11:31:26 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 7BB84E03F5; Wed, 29 Apr 2009 11:30:34 +0000 (UTC) Received: from mailfilter6.ihug.co.nz (mailfilter6.ihug.co.nz [203.109.136.6]) by pigeon.gentoo.org (Postfix) with ESMTP id F3551E042D for ; Wed, 29 Apr 2009 11:30:33 +0000 (UTC) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AlQBAL+LX0l2XMad/2dsb2JhbAAIyXKFcoFp X-IronPort-AV: E=Sophos;i="4.40,265,1238932800"; d="scan'208";a="93239813" Received: from 118-92-198-157.dsl.dyn.ihug.co.nz (HELO [192.168.0.3]) ([118.92.198.157]) by smtp.mailfilter6.ihug.co.nz with ESMTP; 29 Apr 2009 23:30:32 +1200 Message-ID: <49F83A4A.6060907@gentoo.org> Date: Wed, 29 Apr 2009 23:30:18 +1200 From: Alistair Bush User-Agent: Thunderbird 2.0.0.21 (X11/20090325) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-java@lists.gentoo.org MIME-Version: 1.0 To: gentoo-java@lists.gentoo.org Subject: [gentoo-java] Bug 225659: java-pkg_jarfrom --virtual virtual-name jarname.jar fails with JVM providers. X-Enigmail-Version: 0.95.7 OpenPGP: url= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Archives-Salt: 0cfdaf0e-92ee-4e97-b880-1f923fe03823 X-Archives-Hash: deaf3e56c9f064860e1de6c76055c83b I would like the discuss the solutions to bug 225659 [1] When using jar-from with a virtual that can return both a jar or a "vm provider" there is no way to specify a target_jar when calling jar from. basically jar-from calls java-config -p virtual with may or may not return a string with paths to jars within it. In the case of there being a vm provider java-config will return an empty string. Currently jar-from errors as it is unable to find the target_jar from returned string and is therefore unable to link to that jar. Now we can fix this issue but simply ignoring the fact that we didn't find the target_jar when --virtual is specified. Basically see [2]. This will therefore never error, even when the virtual does not have vm providers and is only ever satisfied by a package. as an example java-pkg_jar-from --virtual javamail target_vm_which_is_not_provided_by_anything.jar would not error, it also wouldn't create the link it is meant to. So Questions: Should jar-from maintain its current behavour? Are there any other solutions to this issue? Any other comments? [1] https://bugs.gentoo.org/225659 [2] Index: java-utils-2.eclass =================================================================== RCS file: /var/cvsroot/gentoo-x86/eclass/java-utils-2.eclass,v retrieving revision 1.126 diff -u -b -B -r1.126 java-utils-2.eclass --- java-utils-2.eclass 31 Mar 2009 19:19:20 -0000 1.126 +++ java-utils-2.eclass 29 Apr 2009 11:13:07 -0000 @@ -965,9 +965,10 @@ if [[ -z "${target_jar}" ]] ; then return 0 # otherwise, die bitterly - else + elif [[ ! -z "${virtual}" ]] die "Failed to find ${target_jar:-jar} in ${target_pkg}" fi + return 0 } # ------------------------------------------------------------------------------