public inbox for gentoo-java@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Petteri Räty" <betelgeuse@gentoo.org>
To: Gentoo Java <gentoo-java@lists.gentoo.org>
Subject: [gentoo-java] Using export VAR= instead of unset
Date: Mon, 26 Nov 2007 22:38:35 +0200	[thread overview]
Message-ID: <474B2ECB.9000900@gentoo.org> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 203 bytes --]

See https://bugs.gentoo.org/show_bug.cgi?id=189417#c11
I committed the attached patch that should make java-utils-2 again
behave in the same way as before the hooks were removed.

Regards,
Petteri

[-- Attachment #1.2: env-handling.patch --]
[-- Type: text/plain, Size: 1372 bytes --]

Index: java-utils-2.eclass
===================================================================
RCS file: /var/cvsroot/gentoo-x86/eclass/java-utils-2.eclass,v
retrieving revision 1.96
diff -u -r1.96 java-utils-2.eclass
--- java-utils-2.eclass	25 Nov 2007 07:51:41 -0000	1.96
+++ java-utils-2.eclass	26 Nov 2007 20:36:46 -0000
@@ -2049,6 +2079,7 @@
 #
 # -----------------------------------------------------------------------------
 java-pkg_init() {
+	debug-print-function ${FUNCNAME} $*
 	unset JAVAC
 	unset JAVA_HOME
 
@@ -2066,7 +2097,7 @@
 	fi
 
 	if [[ -z ${accept} ]]; then
-		unset _JAVA_OPTIONS
+		export _JAVA_OPTIONS=
 		# phase hooks make this run many times without this
 		I_WANT_GLOBAL_JAVA_OPTIONS="true"
 	fi
@@ -2084,15 +2115,18 @@
 	# Do some QA checks
 	java-pkg_check-jikes
 
+	# Can't use unset here because Portage does not save the unset
+	# see https://bugs.gentoo.org/show_bug.cgi?id=189417#c11
+
 	# When users have crazy classpaths some packages can fail to compile.
 	# and everything should work with empty CLASSPATH.
 	# This also helps prevent unexpected dependencies on random things
 	# from the CLASSPATH.
-	unset CLASSPATH
+	export CLASSPATH=
 
 	# Unset external ANT_ stuff
-	unset ANT_TASKS
-	unset ANT_OPTS
+	export ANT_TASKS=
+	export ANT_OPTS=
 }
 
 # ------------------------------------------------------------------------------

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]

                 reply	other threads:[~2007-11-26 20:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=474B2ECB.9000900@gentoo.org \
    --to=betelgeuse@gentoo.org \
    --cc=gentoo-java@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox