From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by nuthatch.gentoo.org with esmtp (Exim 4.62) (envelope-from ) id 1HNbnJ-0001aR-RT for garchives@archives.gentoo.org; Sat, 03 Mar 2007 21:29:34 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.14.0/8.14.0) with SMTP id l23LSmDn020180; Sat, 3 Mar 2007 21:28:48 GMT Received: from gw03.mail.saunalahti.fi (gw03.mail.saunalahti.fi [195.197.172.111]) by robin.gentoo.org (8.14.0/8.14.0) with ESMTP id l23LSml6020175 for ; Sat, 3 Mar 2007 21:28:48 GMT Received: from mrp2.mail.saunalahti.fi (mrp2.mail.saunalahti.fi [62.142.5.31]) by gw03.mail.saunalahti.fi (Postfix) with ESMTP id 183A72161C0 for ; Sat, 3 Mar 2007 23:28:48 +0200 (EET) Received: from [192.168.150.87] (a91-152-108-214.elisa-laajakaista.fi [91.152.108.214]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mrp2.mail.saunalahti.fi (Postfix) with ESMTP id A955D598001 for ; Sat, 3 Mar 2007 23:28:46 +0200 (EET) Message-ID: <45E9E642.8000906@gentoo.org> Date: Sat, 03 Mar 2007 23:18:58 +0200 From: =?UTF-8?B?UGV0dGVyaSBSw6R0eQ==?= User-Agent: Thunderbird 2.0b1 (X11/20070112) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-java@gentoo.org MIME-Version: 1.0 To: gentoo-java@lists.gentoo.org Subject: Re: [gentoo-java] QA checks in the eclass References: <45E9DC52.7050408@gentoo.org> <45E9E58A.9020108@gentoo.org> In-Reply-To: <45E9E58A.9020108@gentoo.org> X-Enigmail-Version: 0.94.1.2.0 OpenPGP: url=http://users.tkk.fi/~praty/public.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigDF8795DA43532E5E87C2EACA" X-Archives-Salt: 65ebd9e9-d7a7-4cd4-bd89-9deaf071e007 X-Archives-Hash: 89fdb11030bf08ac4b3dd409a412fa0b This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigDF8795DA43532E5E87C2EACA Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Vlastimil Babka wrote: >=20 > Also, when it checks foo is in IUSE, why not check "use foo" as well? > Heck, why don't even change the functions so they only perform their > stuff when "use foo" holds (this way you get a free QA check for IUSE > right in useq()), and get rid of the "use foo && java-pkg_dofoo" idiom?= > :) If we agree we *ALWAYS* want to install this javadocs/source/ always= > based on flags (maybe there could be some nocheck variants if needed). >=20 Yeah I was suggesting to checking the use flag inside the eclass to nichoj but he thinks the current way is more clear to the reader. Yeah good point about use already checking it so my patch is stupid for that part so I guess we should go for a cleaner eclass in this case. Regards, Petteri --------------enigDF8795DA43532E5E87C2EACA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.2 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFF6eZCcxLzpIGCsLQRAt8jAJ4gey1OFoywdiWB2IMG1Waly+sDfgCaApcJ E1o54Gc0QUHL7ikAn0S93Wg= =4+F4 -----END PGP SIGNATURE----- --------------enigDF8795DA43532E5E87C2EACA-- -- gentoo-java@gentoo.org mailing list