From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by nuthatch.gentoo.org with esmtp (Exim 4.62) (envelope-from ) id 1HNb8o-00070x-5V for garchives@archives.gentoo.org; Sat, 03 Mar 2007 20:47:42 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.14.0/8.14.0) with SMTP id l23KkNS0017590; Sat, 3 Mar 2007 20:46:23 GMT Received: from gw01.mail.saunalahti.fi (gw01.mail.saunalahti.fi [195.197.172.115]) by robin.gentoo.org (8.14.0/8.14.0) with ESMTP id l23KkM20017567 for ; Sat, 3 Mar 2007 20:46:22 GMT Received: from mrp1.mail.saunalahti.fi (mrp1.mail.saunalahti.fi [62.142.5.30]) by gw01.mail.saunalahti.fi (Postfix) with ESMTP id 3772D151505 for ; Sat, 3 Mar 2007 22:46:23 +0200 (EET) Received: from [192.168.150.87] (a91-152-108-214.elisa-laajakaista.fi [91.152.108.214]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mrp1.mail.saunalahti.fi (Postfix) with ESMTP id D34B933C002 for ; Sat, 3 Mar 2007 22:46:21 +0200 (EET) Message-ID: <45E9DC52.7050408@gentoo.org> Date: Sat, 03 Mar 2007 22:36:34 +0200 From: =?UTF-8?B?UGV0dGVyaSBSw6R0eQ==?= User-Agent: Thunderbird 2.0b1 (X11/20070112) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-java@gentoo.org MIME-Version: 1.0 To: gentoo-java@lists.gentoo.org Subject: [gentoo-java] QA checks in the eclass X-Enigmail-Version: 0.94.1.2.0 OpenPGP: url=http://users.tkk.fi/~praty/public.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig938B4355622EB980C192FD60" X-Archives-Salt: 6b95e8c1-089f-403d-b61d-11cd5960bb24 X-Archives-Hash: 95dcb2adc2b804bd51d6b4973130fccd This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig938B4355622EB980C192FD60 Content-Type: multipart/mixed; boundary="------------090602000607030805060504" This is a multi-part message in MIME format. --------------090602000607030805060504 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Added some QA checks and changed java-pkg_announce-qa-violation to use ewarn to make it show better. Any objections? Will commit sometimes next week if there aren't any. Regards, Petteri --------------090602000607030805060504 Content-Type: text/x-patch; name="java-qa-checks.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline; filename="java-qa-checks.patch" Index: java-utils-2.eclass =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /var/cvsroot/gentoo-x86/eclass/java-utils-2.eclass,v retrieving revision 1.63 diff -u -r1.63 java-utils-2.eclass --- java-utils-2.eclass 3 Mar 2007 20:37:35 -0000 1.63 +++ java-utils-2.eclass 3 Mar 2007 20:44:45 -0000 @@ -205,6 +205,10 @@ =20 java-pkg_check-phase install =20 + if ! hasq source ${IUSE}; then + java-pkg_announce-qa-violation "${FUNCNAME} called without source in I= USE" + fi + local dest=3D/usr/share/doc/${PF}/examples if [[ ${#} =3D 1 && -d ${1} ]]; then INSDESTTREE=3D"${dest}" doins -r ${1}/* || die "Installing examples fa= iled" @@ -550,6 +554,10 @@ =20 java-pkg_check-phase install =20 + if ! hasq doc ${IUSE}; then + java-pkg_announce-qa-violation "${FUNCNAME} called without doc in IUSE= " + fi + [[ -z "${dir}" ]] && die "Must specify a directory!" [[ ! -d "${dir}" ]] && die "${dir} does not exist, or isn't a directory= !" =20 @@ -586,8 +594,9 @@ debug-print-function ${FUNCNAME} $* =20 [ ${#} -lt 1 ] && die "At least one argument needed" + if ! hasq source ${IUSE}; then - echo "Java QA Notice: ${FUNCNAME} called without source in IUSE" + java-pkg_announce-qa-violation "${FUNCNAME} called without source in I= USE" fi =20 java-pkg_check-phase install @@ -2323,7 +2332,7 @@ =20 java-pkg_announce-qa-violation() { if is-java-strict; then - echo "Java QA Notice: $@" >&2 + ewarn "Java QA Notice: $@" increment-qa-violations fi } --------------090602000607030805060504-- --------------enig938B4355622EB980C192FD60 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.2 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFF6dxScxLzpIGCsLQRAsefAJ0UzrjG6aEDdieyt+0JZ/oUZD36xgCdHr9m CMNXGijNRCY/WcSfZ0xrDKc= =oLOr -----END PGP SIGNATURE----- --------------enig938B4355622EB980C192FD60-- -- gentoo-java@gentoo.org mailing list