From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by nuthatch.gentoo.org with esmtp (Exim 4.62) (envelope-from ) id 1HBbQO-0003T1-4y for garchives@archives.gentoo.org; Mon, 29 Jan 2007 18:40:16 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.13.8/8.13.8) with SMTP id l0TId7OL002044; Mon, 29 Jan 2007 18:39:07 GMT Received: from gw01.mail.saunalahti.fi (gw01.mail.saunalahti.fi [195.197.172.115]) by robin.gentoo.org (8.13.8/8.13.8) with ESMTP id l0TId6AN002023 for ; Mon, 29 Jan 2007 18:39:06 GMT Received: from mrp3.mail.saunalahti.fi (mrp3.mail.saunalahti.fi [62.142.5.32]) by gw01.mail.saunalahti.fi (Postfix) with ESMTP id B375F151781; Mon, 29 Jan 2007 20:39:06 +0200 (EET) Received: from [192.168.150.185] (a91-152-108-214.elisa-laajakaista.fi [91.152.108.214]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mrp3.mail.saunalahti.fi (Postfix) with ESMTP id 2B74E708001; Mon, 29 Jan 2007 20:39:04 +0200 (EET) Message-ID: <45BE3F4C.5020109@gentoo.org> Date: Mon, 29 Jan 2007 20:39:08 +0200 From: =?UTF-8?B?UGV0dGVyaSBSw6R0eQ==?= User-Agent: Thunderbird 2.0b1 (X11/20070112) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-java@gentoo.org MIME-Version: 1.0 To: gentoo-java@lists.gentoo.org CC: Vlastimil Babka Subject: Re: [gentoo-java] new proposed enhancement to java-pkg_jarfrom() References: <45B88710.2080405@gentoo.org> In-Reply-To: <45B88710.2080405@gentoo.org> X-Enigmail-Version: 0.94.1.2.0 OpenPGP: url=http://users.tkk.fi/~praty/public.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigB0A78406E3BF1D31D390C609" X-Archives-Salt: f8077d62-bf17-4121-a7a2-4a8e12973411 X-Archives-Hash: 43df2847e511bce23a2f83e02c4e29f5 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigB0A78406E3BF1D31D390C609 Content-Type: multipart/mixed; boundary="------------080108010802020402060600" This is a multi-part message in MIME format. --------------080108010802020402060600 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Vlastimil Babka wrote: > Attached a patch, will commit if no-one objects. >=20 Otherwise fine but you managed to break for example eclipse-sdk by missing one conditional return in the code. Regards, Petteri --------------080108010802020402060600 Content-Type: text/x-patch; name="caster-broke-it.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline; filename="caster-broke-it.patch" Index: java-utils-2.eclass =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /var/cvsroot/gentoo-x86/eclass/java-utils-2.eclass,v retrieving revision 1.53 diff -u -r1.53 java-utils-2.eclass --- java-utils-2.eclass 28 Jan 2007 21:11:42 -0000 1.53 +++ java-utils-2.eclass 29 Jan 2007 18:35:08 -0000 @@ -827,6 +827,7 @@ ln -snf "${jar}" "${destjar}" \ || die "Failed to make symlink from ${jar} to ${destjar}" [[ -z "${build_only}" ]] && java-pkg_record-jar_ "${target_pkg}" "${j= ar}" + popd > /dev/null return 0 fi done --------------080108010802020402060600-- --------------enigB0A78406E3BF1D31D390C609 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.1 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFFvj9McxLzpIGCsLQRAkYtAKCY9Q3SScbTed+wzsJNgEGAAB25HgCfXKFX XjPDkp2dqtWUXfsvh/p3Rnc= =uMtk -----END PGP SIGNATURE----- --------------enigB0A78406E3BF1D31D390C609-- -- gentoo-java@gentoo.org mailing list