Re: [gentoo-java] new proposed enhancement to java-pkg_jarfrom()

["Petteri Räty" <betelgeuse@gentoo.org>]

[-- Attachment #1.1: Type: text/plain, Size: 216 bytes --]

Vlastimil Babka wrote:
> Attached a patch, will commit if no-one objects.
> 

Otherwise fine but you managed to break for example eclipse-sdk by
missing one conditional return in the code.

Regards,
Petteri

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: caster-broke-it.patch --]
[-- Type: text/x-patch; name="caster-broke-it.patch", Size: 584 bytes --]

Index: java-utils-2.eclass
===================================================================
RCS file: /var/cvsroot/gentoo-x86/eclass/java-utils-2.eclass,v
retrieving revision 1.53
diff -u -r1.53 java-utils-2.eclass
--- java-utils-2.eclass	28 Jan 2007 21:11:42 -0000	1.53
+++ java-utils-2.eclass	29 Jan 2007 18:35:08 -0000
@@ -827,6 +827,7 @@
 			ln -snf "${jar}" "${destjar}" \
 				|| die "Failed to make symlink from ${jar} to ${destjar}"
 			[[ -z "${build_only}" ]] && java-pkg_record-jar_ "${target_pkg}" "${jar}"
+			popd > /dev/null
 			return 0
 		fi
 	done

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]