[gentoo-java] Moving depends to eclasses

[gentoo-java] Moving depends to eclasses

[Petteri Räty]

Attached patch does two things:
1. in ebuild:
JAVA_PKG_IUSE="doc source"
inherit java-pkg-2

This will automatically give you source? ( app-arch/zip ) to DEPEND
If JAVA_PKG_IUSE is not specified before inherit, nothing changes.

2. Will add dev-java/ant-core to java-ant-2.eclass DEPEND. I can't think
of any valid use for this eclass without ant-core. This would remove the
need to specify ant-core in almost all of our ebuilds.

So what do you think?

Regards,
Petteri
-- 
gentoo-java@gentoo.org mailing list

Re: [gentoo-java] Moving depends to eclasses

[Vlastimil Babka]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Petteri Räty wrote:
> Attached patch

ORLY? Where? :)

> 1. in ebuild:
> JAVA_PKG_IUSE="doc source"
> inherit java-pkg-2

Why doc? Just in case in future?
Good idea wit the source though.

> 2. Will add dev-java/ant-core to java-ant-2.eclass DEPEND. I can't think
> of any valid use for this eclass without ant-core. This would remove the
> need to specify ant-core in almost all of our ebuilds.

Fine. Is there a var to disable this if I need to fine-tune ant-core
version or in ant-core.ebuild so it doesn't depend on itself? :)

- --
Vlastimil Babka (Caster)
Gentoo/Java
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFqXZwtbrAj05h3oQRAnsyAKCTT6lNveLkj7BPK2qNsJGGR/X6eACbB6xB
oRFZFBRarflDI/uWBtnMiu8=
=TE3K
-----END PGP SIGNATURE-----
-- 
gentoo-java@gentoo.org mailing list

Re: [gentoo-java] Moving depends to eclasses

[Petteri Räty]

[-- Attachment #1: Type: text/plain, Size: 862 bytes --]



Vlastimil Babka wrote:
> Petteri Räty wrote:
>> Attached patch
> 
> ORLY? Where? :)

Well patch that should be attached this time.

> 
>> 1. in ebuild:
>> JAVA_PKG_IUSE="doc source"
>> inherit java-pkg-2
> 
> Why doc? Just in case in future?
> Good idea wit the source though.

The point is that you don't have to have a separate IUSE in the ebuild.

> 
>> 2. Will add dev-java/ant-core to java-ant-2.eclass DEPEND. I can't think
>> of any valid use for this eclass without ant-core. This would remove the
>> need to specify ant-core in almost all of our ebuilds.
> 
> Fine. Is there a var to disable this if I need to fine-tune ant-core
> version or in ant-core.ebuild so it doesn't depend on itself? :)
> 

Hmm ant-core yes, so for that we would need a disable variable. Will see
to writing that support.

Regards,
Petteri

[-- Attachment #2: java-eclasses-auto-depends.patch --]
[-- Type: text/plain, Size: 1954 bytes --]

Index: java-ant-2.eclass
===================================================================
RCS file: /var/cvsroot/gentoo-x86/eclass/java-ant-2.eclass,v
retrieving revision 1.12
diff -u -r1.12 java-ant-2.eclass
--- java-ant-2.eclass	12 Jan 2007 14:03:16 -0000	1.12
+++ java-ant-2.eclass	13 Jan 2007 23:34:18 -0000
@@ -19,7 +19,10 @@
 # they use the appropriate 'target' and 'source' attributes.
 
 # We need some tools from javatoolkit. We also need portage 2.1 for phase hooks
-DEPEND=">=dev-java/javatoolkit-0.1.5 ${JAVA_PKG_PORTAGE_DEP}"
+DEPEND="
+	>=dev-java/javatoolkit-0.1.5 
+	${JAVA_PKG_PORTAGE_DEP}
+	dev-java/ant-core"
 
 # ------------------------------------------------------------------------------
 # @global JAVA_PKG_BSFIX
Index: java-pkg-2.eclass
===================================================================
RCS file: /var/cvsroot/gentoo-x86/eclass/java-pkg-2.eclass,v
retrieving revision 1.12
diff -u -r1.12 java-pkg-2.eclass
--- java-pkg-2.eclass	12 Jan 2007 16:12:15 -0000	1.12
+++ java-pkg-2.eclass	13 Jan 2007 23:34:18 -0000
@@ -18,6 +18,15 @@
 # -----------------------------------------------------------------------------
 
 # ------------------------------------------------------------------------------
+# @IUSE
+#
+# ebuilds using this eclass can set JAVA_PKG_IUSE and then this eclass
+# will automatically add deps for them.
+#
+# ------------------------------------------------------------------------------
+IUSE="${JAVA_PKG_IUSE}"
+
+# ------------------------------------------------------------------------------
 # @depend
 #
 # Java packages need java-config, and a fairly new release of Portage.
@@ -26,6 +35,8 @@
 # ------------------------------------------------------------------------------
 DEPEND="${JAVA_PKG_E_DEPEND}"
 
+hasq source ${JAVA_PKG_IUSE} && DEPEND="${DEPEND} source? ( app-arch/zip )"
+
 # ------------------------------------------------------------------------------
 # @rdepend
 #