From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by nuthatch.gentoo.org with esmtp (Exim 4.62) (envelope-from ) id 1H1vJi-0004LH-OK for garchives@archives.gentoo.org; Wed, 03 Jan 2007 01:53:23 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.13.8/8.13.8) with SMTP id l031qYSf020068; Wed, 3 Jan 2007 01:52:34 GMT Received: from smtp02.lnh.mail.rcn.net (smtp02.lnh.mail.rcn.net [207.172.157.102]) by robin.gentoo.org (8.13.8/8.13.8) with ESMTP id l031qXvb022204 for ; Wed, 3 Jan 2007 01:52:33 GMT Received: from mr02.lnh.mail.rcn.net ([207.172.157.22]) by smtp02.lnh.mail.rcn.net with ESMTP; 02 Jan 2007 20:52:34 -0500 Received: from smtp01.lnh.mail.rcn.net (smtp01.lnh.mail.rcn.net [207.172.4.11]) by mr02.lnh.mail.rcn.net (MOS 3.7.5a-GA) with ESMTP id MSO54901; Tue, 2 Jan 2007 20:52:14 -0500 (EST) Received: from 146-115-26-150.c3-0.abr-ubr1.sbo-abr.ma.cable.rcn.com (HELO [192.168.1.7]) ([146.115.26.150]) by smtp01.lnh.mail.rcn.net with ESMTP; 02 Jan 2007 20:52:14 -0500 Message-ID: <459B0C83.3080207@gentoo.org> Date: Tue, 02 Jan 2007 20:53:07 -0500 From: Joshua Nichols User-Agent: Thunderbird 1.5.0.9 (X11/20061228) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-java@gentoo.org MIME-Version: 1.0 To: gentoo-java@lists.gentoo.org Subject: Re: [gentoo-java] Running java-pkg_ensure-no-bundled-jars automatically with JAVA_PKG_STRICT References: <459A84B1.2000503@gentoo.org> In-Reply-To: <459A84B1.2000503@gentoo.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by robin.gentoo.org id l031qYTB020068 X-Archives-Salt: b50b0fef-bc3e-4681-8812-fc325a556a29 X-Archives-Hash: 2333153a882f780c0c84803be8dd3c1a Petteri R=C3=A4ty wrote: > Any objections to the attached patch? It will probably find some false > positives but in those cases one can just use JAVA_PKG_STRICT=3D emerge. > > Regards, > Petteri > =20 > -----------------------------------------------------------------------= - > > Index: java-pkg-2.eclass > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /var/cvsroot/gentoo-x86/eclass/java-pkg-2.eclass,v > retrieving revision 1.8 > diff -u -r1.8 java-pkg-2.eclass > --- java-pkg-2.eclass 18 Dec 2006 10:18:56 -0000 1.8 > +++ java-pkg-2.eclass 2 Jan 2007 16:11:41 -0000 > @@ -84,6 +84,7 @@ > } > =20 > pre_src_compile() { > + is-java-strict && java-pkg_ensure-no-bundled-jars > java-pkg-2_pkg_setup > } > =20 > =20 I'm not sure if we should add this quite yet. Any idea how many packages=20 this would affect? Some problem areas I expect: * Some packages are weird, and jar up their sources inside of their=20 upstream distfile, which we then unpack. So, we'd either need to remove=20 those jars after unpacking, or perhaps add some checks to ensure the=20 bundled jars don't contain class files * Some packages have jars for like tests, or examples, or whatnot. Maybe=20 we need a variable to say what jars are ok? * In some cases, we may be only replacing some jars with jar-from... but=20 perhaps not all of them, or maybe they are meant to replace a jar, but=20 the jar changed names, so both the symlink from jar-from and the=20 original are around. Whitelisting jars should take care of the first two points, and for the=20 latter, well, I suppose those are the type of things this is intended to=20 catch. --=20 Joshua Nichols Gentoo/Java Project Lead --=20 gentoo-java@gentoo.org mailing list