Re: [gentoo-java] Running java-pkg_ensure-no-bundled-jars automatically with JAVA_PKG_STRICT

[Joshua Nichols <nichoj@gentoo.org>]

Petteri Räty wrote:
> Any objections to the attached patch? It will probably find some false
> positives but in those cases one can just use JAVA_PKG_STRICT= emerge.
>
> Regards,
> Petteri
>   
> ------------------------------------------------------------------------
>
> Index: java-pkg-2.eclass
> ===================================================================
> RCS file: /var/cvsroot/gentoo-x86/eclass/java-pkg-2.eclass,v
> retrieving revision 1.8
> diff -u -r1.8 java-pkg-2.eclass
> --- java-pkg-2.eclass	18 Dec 2006 10:18:56 -0000	1.8
> +++ java-pkg-2.eclass	2 Jan 2007 16:11:41 -0000
> @@ -84,6 +84,7 @@
>  }
>  
>  pre_src_compile() {
> +	is-java-strict && java-pkg_ensure-no-bundled-jars
>  	java-pkg-2_pkg_setup
>  }
>  
>   
I'm not sure if we should add this quite yet. Any idea how many packages 
this would affect?

Some problem areas I expect:

* Some packages are weird, and jar up their sources inside of their 
upstream distfile, which we then unpack. So, we'd either need to remove 
those jars after unpacking, or perhaps add some checks to ensure the 
bundled jars don't contain class files
* Some packages have jars for like tests, or examples, or whatnot. Maybe 
we need a variable to say what jars are ok?
* In some cases, we may be only replacing some jars with jar-from... but 
perhaps not all of them, or maybe they are meant to replace a jar, but 
the jar changed names, so both the symlink from jar-from and the 
original are around.

Whitelisting jars should take care of the first two points, and for the 
latter, well, I suppose those are the type of things this is intended to 
catch.

-- 
Joshua Nichols
Gentoo/Java Project Lead
-- 
gentoo-java@gentoo.org mailing list