From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by nuthatch.gentoo.org with esmtp (Exim 4.62) (envelope-from ) id 1GxmSX-0007OA-K6 for garchives@archives.gentoo.org; Fri, 22 Dec 2006 15:37:22 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.13.8/8.13.8) with SMTP id kBMFafkp006201; Fri, 22 Dec 2006 15:36:41 GMT Received: from gw02.mail.saunalahti.fi (gw02.mail.saunalahti.fi [195.197.172.116]) by robin.gentoo.org (8.13.8/8.13.8) with ESMTP id kBMFafBq022667 for ; Fri, 22 Dec 2006 15:36:41 GMT Received: from mrp3.mail.saunalahti.fi (mrp3.mail.saunalahti.fi [62.142.5.32]) by gw02.mail.saunalahti.fi (Postfix) with ESMTP id 7BFDD139677 for ; Fri, 22 Dec 2006 17:36:41 +0200 (EET) Received: from [192.168.150.87] (a88-112-194-247.elisa-laajakaista.fi [88.112.194.247]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mrp3.mail.saunalahti.fi (Postfix) with ESMTP id 2EDE8708001 for ; Fri, 22 Dec 2006 17:36:40 +0200 (EET) Message-ID: <458BFB88.7040103@gentoo.org> Date: Fri, 22 Dec 2006 17:36:40 +0200 From: =?UTF-8?B?UGV0dGVyaSBSw6R0eQ==?= User-Agent: Thunderbird 1.5.0.8 (X11/20061220) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-java@gentoo.org MIME-Version: 1.0 To: gentoo-java@lists.gentoo.org Subject: Re: [gentoo-java] java-vm-2.eclass dependancies References: <458BF6E1.5010409@severinsson.net> In-Reply-To: <458BF6E1.5010409@severinsson.net> X-Enigmail-Version: 0.94.0.0 OpenPGP: url=http://users.tkk.fi/~praty/public.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigFD2A2B15FFEA195933A30028" X-Archives-Salt: 791faa07-36dd-4606-aa3b-9603d76be4a6 X-Archives-Hash: a0b91b6fe77383c64b2204d1c1f1fedb This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigFD2A2B15FFEA195933A30028 Content-Type: multipart/mixed; boundary="------------090708070505060805010304" This is a multi-part message in MIME format. --------------090708070505060805010304 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Jon Severinsson kirjoitti: > Dear Gentoo/Java team >=20 > I recently noticed that sun-jdk-1.5 RDEPEND on =3Djava-config-1.3*, whi= ch > I found quite odd, considering that jdk-1.5 isn't compatible with > java-config-1. >=20 > Digging a bit deeper I found that the problem is in java-vm-2.eclass, > witch doesn't consider JAVA_SUPPORTS_GENERATION_1 when it defines DEPEN= D > and RDEPEND. (It does in the rest of the eclass). >=20 > With the attached patch it does, and the end result works just fine on > both mixed generation systems, and generation 2 only systems, in the > first case with both java-config-1 and java-config-2, and the second > with only java-config-2. >=20 > Please consider adding it to the tree (so I don't have to do it myself > after every emerge --sync on my "pure" java 1.5 / generation 2 system).= >=20 > Regards > - Jonno >=20 > P.S. To get a pure java 1.5 / generation 2 system you'll have to get > creative in packages.keywords, but it is certainly possible. I'm > currently doing it on one system, where HD space is at a premium, and > two VM is overkill just to run tomcat. While java-config-1 isn't exactl= y > a space killer, it's the principle of the thing. After working hard on > getting rid of generation-1 I still can't get rid of this last piece. Attached patch is a bit cleaner. Yeah, I think we can add something like this. Regards, Petteri --------------090708070505060805010304 Content-Type: text/x-patch; name="java-vm-2-deps.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline; filename="java-vm-2-deps.patch" Index: java-vm-2.eclass =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /var/cvsroot/gentoo-x86/eclass/java-vm-2.eclass,v retrieving revision 1.16 diff -u -r1.16 java-vm-2.eclass --- java-vm-2.eclass 11 Nov 2006 00:13:22 -0000 1.16 +++ java-vm-2.eclass 22 Dec 2006 15:35:15 -0000 @@ -18,8 +18,11 @@ =3Ddev-java/java-config-2.0* >=3Dsys-apps/portage-2.1" RDEPEND=3D" - =3Ddev-java/java-config-2.0* - =3Ddev-java/java-config-1.3*" + =3Ddev-java/java-config-2.0*" + +if [[ "${JAVA_SUPPORTS_GENERATION_1}" =3D=3D 'true' ]]; then + RDEPEND=3D"${RDEPEND} =3Ddev-java/java-config-1.3*" +fi =20 export WANT_JAVA_CONFIG=3D2 =20 --------------090708070505060805010304-- --------------enigFD2A2B15FFEA195933A30028 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFFi/uKcxLzpIGCsLQRAkkZAKCaV3wV+LnLBZETuEiwI1UmllzmNgCgioR0 rT+OS/RB/bwDXwRq8XU6BfU= =gk3D -----END PGP SIGNATURE----- --------------enigFD2A2B15FFEA195933A30028-- -- gentoo-java@gentoo.org mailing list