From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by nuthatch.gentoo.org with esmtp (Exim 4.62) (envelope-from ) id 1GtmiJ-0006zn-0G for garchives@archives.gentoo.org; Mon, 11 Dec 2006 15:05:07 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.13.8/8.13.8) with SMTP id kBBF4OKS016588; Mon, 11 Dec 2006 15:04:24 GMT Received: from banta-im.com (roy-rogers.nfic.com [208.231.230.100]) by robin.gentoo.org (8.13.8/8.13.8) with ESMTP id kBBF4N5a016676 for ; Mon, 11 Dec 2006 15:04:23 GMT Received: from by banta-im.com (8.9.3/8.9.3) with ESMTP id KAA04666 for ; Mon, 11 Dec 2006 10:04:21 -0500 (EST) Message-ID: <457D7375.4060803@gentoo.org> Date: Mon, 11 Dec 2006 10:04:21 -0500 From: Joshua Nichols User-Agent: Thunderbird 1.5.0.8 (X11/20061123) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-java@gentoo.org MIME-Version: 1.0 To: gentoo-java@lists.gentoo.org Subject: Re: [gentoo-java] RFC: Default src_compile for java-pkg-2.eclass References: <457AA9BF.6060705@gentoo.org> <457CE72F.7050906@gentoo.org> <457D3A0B.5090301@gentoo.org> In-Reply-To: <457D3A0B.5090301@gentoo.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Archives-Salt: cfaf3af2-8c76-4c0d-aad9-336d16e5c687 X-Archives-Hash: 4f701c8a3a499149ae2465e034fd324b Vlastimil Babka wrote: > I wonder if ebuild using those variables would be more typing than > ebuild with own src_compile() :) but not a bad idea anyway. > > The idea is that you don't end up repeating the same code snippet over and over. Instead, you use some variables to configure what targets get called. This helps with maintainence, as if we change src_compile, you don't have to update it in a trillion places. For example, eant dies by itself on error, but a lot of places do eant || die. If we had a default src_compile, you'd have to fix it in exactly one place. > Yeah check is needed, otherwise you'll be trying to compile current -bin > packages without src_compile() in ebuild... > Not sure if any ebuild would use the variable, but why not... > The answer to 'why not' would be added complexity. But some packages would use it, ie, I know some packages have build files at, for example 'build/build.xml'. -- Joshua Nichols Gentoo/Java - Project Lead -- gentoo-java@gentoo.org mailing list