Re: [gentoo-java] RFC: Default src_compile for java-pkg-2.eclass

[Joshua Nichols <nichoj@gentoo.org>]

Vlastimil Babka wrote:
> I wonder if ebuild using those variables would be more typing than
> ebuild with own src_compile() :) but not a bad idea anyway.
>
>   
The idea is that you don't end up repeating the same code snippet over 
and over. Instead, you use some variables to configure what targets get 
called. This helps with maintainence, as if we change src_compile, you 
don't have to update it in a trillion places. For example, eant dies by 
itself on error, but a lot of places do eant || die. If we had a default 
src_compile, you'd have to fix it in exactly one place.
> Yeah check is needed, otherwise you'll be trying to compile current -bin
> packages without src_compile() in ebuild...
> Not sure if any ebuild would use the variable, but why not...
>   
The answer to 'why not' would be added complexity. But some packages 
would use it, ie, I know some packages have build files at, for example 
'build/build.xml'.

-- 
Joshua Nichols
Gentoo/Java - Project Lead

-- 
gentoo-java@gentoo.org mailing list