From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by nuthatch.gentoo.org with esmtp (Exim 4.62) (envelope-from ) id 1GtiuJ-0008LB-9I for garchives@archives.gentoo.org; Mon, 11 Dec 2006 11:01:16 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.13.8/8.13.8) with SMTP id kBBAxH9n026973; Mon, 11 Dec 2006 10:59:17 GMT Received: from slimak.dkm.cz (smtp.dkm.cz [62.24.64.34]) by robin.gentoo.org (8.13.8/8.13.8) with SMTP id kBBAxHbw004194 for ; Mon, 11 Dec 2006 10:59:17 GMT Received: (qmail 10296 invoked by uid 0); 11 Dec 2006 10:59:16 -0000 Received: from r141.net.upc.cz (HELO ?192.168.1.1?) (62.24.83.141) by smtp.dkm.cz with SMTP; 11 Dec 2006 10:59:16 -0000 Message-ID: <457D3A0B.5090301@gentoo.org> Date: Mon, 11 Dec 2006 11:59:23 +0100 From: Vlastimil Babka User-Agent: Thunderbird 2.0b1 (X11/20061210) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-java@gentoo.org MIME-Version: 1.0 To: gentoo-java@lists.gentoo.org Subject: Re: [gentoo-java] RFC: Default src_compile for java-pkg-2.eclass References: <457AA9BF.6060705@gentoo.org> <457CE72F.7050906@gentoo.org> In-Reply-To: <457CE72F.7050906@gentoo.org> X-Enigmail-Version: 0.94.1.0 OpenPGP: id=4E61DE84; url=subkeys.pgp.net Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Archives-Salt: d007f536-f403-4763-adfa-359a05b991c8 X-Archives-Hash: 8dd67f4137edaf8c810d74d631fad21f -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Joshua Nichols wrote: > How many packages would benefit from this? > > Some ways to improve it... maybe have two variables, ie > EANT_BUILD_TARGET, EANT_DOC_TARGET, which could be set and respected by > src_compile, ie: > > java-pkg-2_src_compile() { > local antflags="${EANT_BUILD_TARGET:=jar}" > hasq doc ${IUSE} && antflags="${antflags} $(use_doc > ${EANT_DOC_TARGET})" > eant ${antflags} > } > > By adding that, I think more ebuilds would be able to take advantage of it. > I wonder if ebuild using those variables would be more typing than ebuild with own src_compile() :) but not a bad idea anyway. > One other thing... should definately check for the existence of a > build.xml... and additionally, could have a variable to specify where > the build file lives. Yeah check is needed, otherwise you'll be trying to compile current -bin packages without src_compile() in ebuild... Not sure if any ebuild would use the variable, but why not... - -- Vlastimil Babka (Caster) Gentoo/Java -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFFfToKtbrAj05h3oQRAjklAJ95WFKtG/l9BXPwA3CvFwbprYXEVACaArRY nVl3h/IW+wfgYx0hyvUWvqc= =d2lM -----END PGP SIGNATURE----- -- gentoo-java@gentoo.org mailing list