Re: [gentoo-java] RFC: Default src_compile for java-pkg-2.eclass

[Vlastimil Babka <caster@gentoo.org>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Joshua Nichols wrote:
> How many packages would benefit from this?
> 
> Some ways to improve it... maybe have two variables, ie
> EANT_BUILD_TARGET, EANT_DOC_TARGET,  which could be set and respected by
> src_compile, ie:
> 
> java-pkg-2_src_compile() {
>     local antflags="${EANT_BUILD_TARGET:=jar}"
>     hasq doc ${IUSE} && antflags="${antflags} $(use_doc
> ${EANT_DOC_TARGET})"
>     eant ${antflags}
> }
> 
> By adding that, I think more ebuilds would be able to take advantage of it.
> 

I wonder if ebuild using those variables would be more typing than
ebuild with own src_compile() :) but not a bad idea anyway.

> One other thing... should definately check for the existence of a
> build.xml... and additionally, could have a variable to specify where
> the build file lives.

Yeah check is needed, otherwise you'll be trying to compile current -bin
packages without src_compile() in ebuild...
Not sure if any ebuild would use the variable, but why not...
- --
Vlastimil Babka (Caster)
Gentoo/Java
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFfToKtbrAj05h3oQRAjklAJ95WFKtG/l9BXPwA3CvFwbprYXEVACaArRY
nVl3h/IW+wfgYx0hyvUWvqc=
=d2lM
-----END PGP SIGNATURE-----
-- 
gentoo-java@gentoo.org mailing list