From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by nuthatch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1GQSqU-0007g6-25 for garchives@archives.gentoo.org; Thu, 21 Sep 2006 18:00:22 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.13.8/8.13.6) with SMTP id k8LHwVdn013495; Thu, 21 Sep 2006 17:58:31 GMT Received: from slimak.dkm.cz (slimak.dkm.cz [62.24.64.34]) by robin.gentoo.org (8.13.8/8.13.6) with SMTP id k8LHwUUb028766 for ; Thu, 21 Sep 2006 17:58:30 GMT Received: (qmail 88866 invoked by uid 0); 21 Sep 2006 17:58:29 -0000 Received: from r141.net.upc.cz (HELO ?192.168.1.1?) (62.24.83.141) by slimak.dkm.cz with SMTP; 21 Sep 2006 17:58:29 -0000 Message-ID: <4512D2C4.4000908@gentoo.org> Date: Thu, 21 Sep 2006 19:58:28 +0200 From: Vlastimil Babka User-Agent: Thunderbird 1.5.0.7 (X11/20060917) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-java@gentoo.org MIME-Version: 1.0 To: gentoo-java@lists.gentoo.org Subject: Re: [gentoo-java] generation-2 java eclass References: <200609152007.32247.alon.barlev@gmail.com> <450C8B52.8050707@gentoo.org> <200609201307.51119.alon.barlev@gmail.com> <4511A52B.2010700@gentoo.org> <4511C3B6.5020802@gentoo.org> <9e0cf0bf0609202205l3b79649y93e87f84ab3cdc79@mail.gmail.com> In-Reply-To: <9e0cf0bf0609202205l3b79649y93e87f84ab3cdc79@mail.gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Archives-Salt: 9da516a4-fcb8-44ce-90b6-ac41d14aee79 X-Archives-Hash: 44f1efcacb173e1448025c147a5258d2 Alon Bar-Lev wrote: > Looking at bug#146647, why did you remove the java from the IUSE? I Because the eclass provides it already. Ebuild doesn't need to. > don't think it is a clean to require programmer to define the > JAVA_PKG_OPT_USE before the inherit... Or you need to add a BIG FAT > WARNING at the eclass documentation/description. You're getting it wrong. JAVA_PKG_OPT_USE is just a name for the flag that triggers java support. You need to specify it before inherit line if you want the flag to be called differently than "java" (the default). Not sure if any ebuild ever overrided that, it's just the possibility. > And shouldn't the package append the USE fag (IUSE="${IUSE} > ${JAVA_PKG_OPT_USE}") instead of replacing it? No, portage itself takes care to put eclass-defined and ebuild-defined IUSE together. > And in order to solve the conflict that may introduce when several > eclasses overwrite the pre* functions, shouldn't you EXPORT_FUNCTIONS > them? No, EXPORT_FUNCTIONS is for exporting the phases itself, not phase hooks. Both seem to solve conflict in a way that the later defined/inherited wins, so in the end you get one phase function and one phase hook. -- Vlastimil Babka (Caster) Gentoo/Java -- gentoo-java@gentoo.org mailing list