--- /usr/bin/repoman 2006-07-16 13:37:40.000000000 +0200 +++ repoman 2006-07-16 16:55:25.000000000 +0200 @@ -1051,6 +1051,21 @@ fails["LIVEVCS.stable"].append(x+"/"+y+".ebuild with stable keywords:%s " % bad_stable_keywords) del keyword, bad_stable_keywords + """ + Check for old style java eclasses + #1: old eclasses: + """ + if set(["java-pkg","java-utils"]).intersection(myaux["INHERITED"].split()): + stats["usage.obsolete"] += 1 + fails["usage.obsolete"].append("%s/%s.ebuild: not migrated to generation 2 of java system" % (x, y)) + + """ + #2: not needed USE flags: + """ + if set(["jikes"]).intersection(myaux["IUSE"].split()): + stats["usage.obsolete"] += 1 + fails["usage.obsolete"].append("%s/%s.ebuild: has jikes in IUSE" % (x, y)) + if "--ignore-arches" in myoptions: arches = [[repoman_settings["ARCH"], repoman_settings["ARCH"], repoman_settings["ACCEPT_KEYWORDS"].split()]] @@ -1268,6 +1283,10 @@ continuation_symbol = re.compile(r'(.*[ ]+[\\][ ].*)') line_continuation_quoted = re.compile(r'(\"|\')(([\w ,:;#\[\]\.`=/|\$\^\*{}()\'-])|(\\.))*\1') line_continuation = re.compile(r'([^#]*\S)(\s+|\t)\\$') + java_ant_run = re.compile(r'^\s*ant') + java_source = re.compile(r'.*java-pkg_dosrc.*') + java_had_ant_run_warning=0 + java_had_source_warning=0 linenum=0 previous_line = None for line in input(checkdir+"/"+y+".ebuild"): @@ -1336,6 +1355,18 @@ myerrormsg = "Line continuation (\"\\\") Syntax Error. Line %d" % linenum stats["ebuild.majorsyn"] +=1 fails["ebuild.majorsyn"].append(x+"/"+y+".ebuild: %s" % myerrormsg) + # ant usage check + match = java_ant_run.match(line) + if match and not java_had_ant_run_warning: + stats["usage.obsolete"] += 1 + fails["usage.obsolete"].append(x+"/"+y+".ebuild: runs ant, should use java-ant-2 eclass") + java_had_ant_run_warning=1 + # java-pkg_dosrc without IUSE="source" + match = java_source.match(line) + if match and not java_had_source_warning and 'source' not in myaux['IUSE'].split(): + stats["ebuild.minorsyn"] += 1 + fails["ebuild.minorsyn"].append(x+"/"+y+".ebuild: uses java-pkg_dosrc, but lacks source in IUSE") + java_had_source_warning=1 previous_line = line del previous_line