From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by nuthatch.gentoo.org with esmtp (Exim 4.54) id 1Ep1s5-0004bL-4g for garchives@archives.gentoo.org; Wed, 21 Dec 2005 11:11:01 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.13.5/8.13.5) with SMTP id jBLBAUNo026855; Wed, 21 Dec 2005 11:10:30 GMT Received: from gw01.mail.saunalahti.fi (gw01.mail.saunalahti.fi [195.197.172.115]) by robin.gentoo.org (8.13.5/8.13.5) with ESMTP id jBLBATuF004498 for ; Wed, 21 Dec 2005 11:10:29 GMT Received: from [192.168.150.87] (YYYMMMCCII.dsl.saunalahti.fi [85.76.10.103]) by gw01.mail.saunalahti.fi (Postfix) with ESMTP id AF1B2104295; Wed, 21 Dec 2005 13:10:27 +0200 (EET) Message-ID: <43A93821.1060208@gentoo.org> Date: Wed, 21 Dec 2005 13:10:25 +0200 From: =?UTF-8?B?UGV0dGVyaSBSw6R0eQ==?= User-Agent: Mozilla Thunderbird 1.0.7 (X11/20051206) X-Accept-Language: en-us, en Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-java@gentoo.org MIME-Version: 1.0 To: gentoo-java@lists.gentoo.org CC: Ernst de Haan Subject: Re: [gentoo-java] Re: Installing Javadoc documentation with java-pkg_dohtml References: In-Reply-To: X-Enigmail-Version: 0.92.0.0 OpenPGP: url=http://users.tkk.fi/~praty/public.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigC2A8743264BA2D2F528376B8" X-Archives-Salt: 0e162745-f9f5-4f2d-ad0a-489ea423b9df X-Archives-Hash: 38c6382ab995e76ad43e35c5fa16e55a This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigC2A8743264BA2D2F528376B8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Ernst de Haan wrote: >>While I'm at it, attached is the current version of my xmlenc ebuild. >>As this is my very first Ebuild, feedback is highly appreciated. > > > This time as a plain text .ebuild file. Comments are highly appreciated! > Here we go. > KEYWORDS="~x86 ~ppc ~sparc ~amd64" Do you have all these arches to test with? http://dev.gentoo.org/~plasmaroo/devmanual/keywording/ > src_compile() { > local antflags="jar" > use debug && antflags="-Djavac.debug=true ${antflags}" > use jikes && antflags="-Dbuild.compiler=jikes ${antflags}" > einfo "Ant flags: ${antflags}" We don't einfo the antflags like this because there is nothing of interest to the user. Feel free to use them for debugging but don't leave them to the final ebuild. > ant ${antflags} || die "Compilation failed." > use doc && ( ant javadoc || die "Javadoc generation failed." ) Using parenthesis like this makes a subshell ( see man bash ). dieing inside a subshell will not quit like you expect it to. Why not just add javadoc to antflags? > } > > src_install() { > java-pkg_dojar build/xmlenc.jar java-pkd_dojar build/*.jar is probably more future proof so when version bumping new jars are not missed. Please note that these comments are only based on looking at the code. I might find more if I ever get to actually testing it. Thanks for the work so far. http://www.gentoo.org/doc/en/ebuild-submit.xml Regards, Petteri --------------enigC2A8743264BA2D2F528376B8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFDqTgkcxLzpIGCsLQRAh8pAJ0ZDOiCDgVyNuHqnycNa+lz3GtsNwCePfav 1IUagtpzG0STFfABG1uwvlo= =jw3e -----END PGP SIGNATURE----- --------------enigC2A8743264BA2D2F528376B8-- -- gentoo-java@gentoo.org mailing list