From: Hanno Meyer-Thurow <h.mth@web.de>
To: gentoo-java@lists.gentoo.org
Subject: Re: [gentoo-java] RFC: Local Javadoc Linking
Date: Sat, 24 Oct 2009 12:06:29 +0200 [thread overview]
Message-ID: <20091024120629.1d9adc04@ana.manna.org> (raw)
In-Reply-To: <20091023162229.GH29871@vulcan.guest.intuitivelyobvious.net>
On Fri, 23 Oct 2009 11:22:30 -0500
Daniel Solano Gómez <gentoo@sattvik.com> wrote:
> Hello, all,
Hi there!
> I have come up with an initial implementation for this and would like to
> get some feedback from other people. ...
> 2. Modifications to the java-ant-2.eclass: I added a new function
> java-ant_link-javadoc() that does the work of looking up local
> documentation and calling the helper script. I also added a hook to the
> function from java-ant-2_src-configure(). This patch is available at:
> https://bugs.gentoo.org/attachment.cgi?id=3D207945
There are two things in the eclass patch I would fix. ;)
1. I recommend the subshell call '$(...)' instead of the old-style '`...`'.
2. There is an hamcrest comment in java-ant_link-javadoc() ?!
> When java-ant_link-javadoc() is called, it first checks to see if
> java-sdk-docs is installed, and if so gets the path to the API
> documentation.
I would add 'doc? ( dev-java/java-sdk-docs:${whatever build vm is used} )'
to java-pkg-2.eclass. But I guess then many will complain. :D
My two cents. :)
Regards,
Hanno
next prev parent reply other threads:[~2009-10-24 10:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-23 16:22 [gentoo-java] RFC: Local Javadoc Linking Daniel Solano Gómez
2009-10-24 10:06 ` Hanno Meyer-Thurow [this message]
2009-10-24 12:50 ` Petteri Räty
2009-10-24 14:34 ` Hanno Meyer-Thurow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091024120629.1d9adc04@ana.manna.org \
--to=h.mth@web.de \
--cc=gentoo-java@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox