From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1M16hY-0008Mn-Py for garchives@archives.gentoo.org; Mon, 04 May 2009 22:31:57 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 316DCE04E1; Mon, 4 May 2009 22:31:56 +0000 (UTC) Received: from mail-ew0-f165.google.com (mail-ew0-f165.google.com [209.85.219.165]) by pigeon.gentoo.org (Postfix) with ESMTP id E9144E04E1 for ; Mon, 4 May 2009 22:31:55 +0000 (UTC) Received: by ewy9 with SMTP id 9so4050121ewy.34 for ; Mon, 04 May 2009 15:31:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:organization:to:subject :date:user-agent:references:in-reply-to:x-face:mime-version :content-type:content-transfer-encoding:message-id; bh=dKmXJlk11hASkD1YtNiNi1Dyxwg4fC2RGnW4ANZ1uwg=; b=TCNFon0Pl8amhfS2sn/s7RinWUeCy1zLQQihnDcxe5y8/ZmZHdlh3lZiWTKI/cp/9y QY7R3rI6o0KdWWzH3BdBrmfaIZQUPH8CQS4jUGODpr21Na3d22FsGGDyfwkfIaXojK5K F+xqgKY6CoQ2oYwKiobYUSmYCtA62fYjf5APg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:organization:to:subject:date:user-agent:references:in-reply-to :x-face:mime-version:content-type:content-transfer-encoding :message-id; b=hH5hCdp2afr/VQJehLT9cIlKGXbcjMifkiXrfb7NRDf7631W0TXjmh5Yl2NbWR4bgP LPuGFDT2C5cqZcaxK63vQ/uHqXclyNFnYujWasrNVhvSVuKjmSEMm6+Ue+qlCCAeLkXw WUdPnnjSGdZGv4lvzf6UNCQgRX5CFrlz43i6M= Received: by 10.216.25.209 with SMTP id z59mr2057498wez.204.1241476315328; Mon, 04 May 2009 15:31:55 -0700 (PDT) Received: from tiulk.localnet (chello084115149052.4.graz.surfer.at [84.115.149.52]) by mx.google.com with ESMTPS id 5sm2035eyh.0.2009.05.04.15.31.54 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 04 May 2009 15:31:55 -0700 (PDT) From: Mario Fetka Organization: Privat To: gentoo-java@lists.gentoo.org Subject: Re: [gentoo-java] plz review some ebuilds Date: Tue, 5 May 2009 00:31:55 +0200 User-Agent: KMail/1.11.90 (Linux/2.6.29-geos_one-r1; KDE/4.2.71; x86_64; ; ) References: <200905041934.55112.fetka@arge.at> <49FF34E7.8000404@gentoo.org> In-Reply-To: <49FF34E7.8000404@gentoo.org> X-Face: 'cfWQXt=t6cs`O=>n)ZZa4~6oCaF\N'0rt{b1Cs(bVy_y_H~9>:>^Lq:"yd,Cjb]UL])x?7Uh'I[?k}9_.LO{M_Rg $#T\h3T!Nbd0!$!?wzD[4`]@%Qw(5,)TTz6}dKZZ?GfcLe List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-java@lists.gentoo.org MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200905050031.56013.mario.fetka@gmail.com> X-Archives-Salt: 2795635f-ee62-4eb6-8cdd-d4561846be64 X-Archives-Hash: dad9e5a38b8dc82be9d15affcb41696d On Monday, 4. May 2009 20:33:11 Vlastimil Babka wrote: > Mario Fetka wrote: > > Hallo Gentoo Java Team, > > > > can someone plz review some java related ebuilds[1] > > > > dev-java/isrt > > dev-java/isnativec > > dev-java/isfreetype > > dev-java/iscwt > > dev-java/jPod > > dev-java/jPodRenderer > > dev-java/jbig2 > > app-text/pdfsam > > Hi, just a quick... I'll talk about iscwt-5.0.20081218.ebuild but most > should apply to others too. > > depends on swt:3.4 using a slot dep without EAPI=1 (or later) which > should not even work. In general, use EAPI=2 and specify slot deps for > everything dev-java except jdk/jre (even explicitly :0 as it eases > future upgrades). With EAPI=2 you can call 'default' instead of 'unpack > $A; cd $S;'. The mkdir and cp calls should have appen '|| die' > > Move doc from IUSE to JAVA_PKG_IUSE. > The creation of build.properties is tedious, overriding the classpath > (see below) should be easier. > What is the ${antflags} doing in src_compile? Should not be there. Also > there should be just one eant call and using $(use_doc) as parameter > will add 'javadoc' based on the flag. > Also the whole src_compile (and the build.properties stuff) could be > replaced with this: > > JAVA_ANT_REWRITE_CLASSPATH="true" > EANT_GENTOO_CLASSPATH="isnativec,isrt,jna" > > Not tested, so some details might vary. Hope it helps. > Caster > > > before i will put them into bugzilla > > > > thx in av > > Mario > > > > [1]http://tinyurl.com/co97l6 > > http://tinyurl.com/dg3vhv all suggestions applied will put on bugzi in a view days