Re: [gentoo-java] mockobjects-0.09-r1 won't build against junit-3.8.2

[David Emmett <daisy@xs4all.nl>]

[-- Attachment #1: Type: text/plain, Size: 1374 bytes --]

On Sunday 07 January 2007 17:24, David Emmett wrote:
> Hi,
>
> I just submitted a bug in the Gentoo Linux product, bug #160711
>
> I updated my system over Christmas, and then tried to emerge groovy. It
> kept failling because of a visibility change between junit 3.8.1 and junit
> 3.8.2. The junit.framework.Assert.failNotEquals() method had it's
> visibility changed from private to public between junit version 3.8.1 and
> 3.8.2.
>
> mockobjects has a class com.mockobjects.util.AssertMo which extends Assert,
> and overrides the failNotEquals() method, but declares it protected. This
> means that mockobjects will no longer compile against junit 3.8.2. The fix
> is the change the method (at line 81 of com.mockobjects.util.AssertMo) from
> protected to public. I have not worked with epatch, so I don't know how it
> works, otherwise I would have submitted a patch. I'll try and figure it out
> and submit a patch anyway.
>
> I have also submitted this bug to the mockobjects project. Hopefully, they
> will also fix this problem.
>

I found out how to make a patch (is it really as simple as doing diff -u?), 
and have attached the patch file. This patch file needs to be added to the 
existing patch file for mockobjects-0.09-r1 (which patches the build.xml 
file).

Hope this is useful,

David

-- 
----
http://www.motogpmatters.com/ - MotoGP News and Race Reports

[-- Attachment #2: assert.patch --]
[-- Type: text/x-diff, Size: 363 bytes --]

--- AssertMo.java	2007-01-07 17:33:53.000000000 +0100
+++ AssertMo.java.orig	2007-01-07 17:35:10.000000000 +0100
@@ -77,7 +77,7 @@
         assertTrue("Should not have verified", threwException);
     }
 
-    public static void failNotEquals(
+    static protected void failNotEquals(
         String message,
         Object expected,
         Object actual) {